From 01d7c467762825c4af092e137352a1491d0af879 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Thu, 22 Oct 2020 17:07:51 +0200 Subject: [PATCH] Revert "src: ignore GCC -Wcast-function-type for v8.h" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit f21cf456bf36bd73d8cb6715c745e23efc22a29f as this has now been included in the V8 version being used. PR-URL: https://github.com/nodejs/node/pull/35758 Refs: https://github.com/v8/v8/commit/f08cbfdc4051266e4200b6e26775d35307b1259b Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Michaël Zasso Reviewed-By: Gireesh Punathil Reviewed-By: Denys Otrishko Reviewed-By: David Carlier Reviewed-By: Rich Trott --- src/string_bytes.h | 7 ------- test/cctest/test_aliased_buffer.cc | 7 ------- 2 files changed, 14 deletions(-) diff --git a/src/string_bytes.h b/src/string_bytes.h index e11b73b69e10b7..69bb828e018cb0 100644 --- a/src/string_bytes.h +++ b/src/string_bytes.h @@ -26,14 +26,7 @@ // Decodes a v8::Local or Buffer to a raw char* -#if (__GNUC__ >= 8) && !defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wcast-function-type" -#endif #include "v8.h" -#if (__GNUC__ >= 8) && !defined(__clang__) -#pragma GCC diagnostic pop -#endif #include "env-inl.h" #include diff --git a/test/cctest/test_aliased_buffer.cc b/test/cctest/test_aliased_buffer.cc index 4dab70d0b576cb..ba947700c1bf27 100644 --- a/test/cctest/test_aliased_buffer.cc +++ b/test/cctest/test_aliased_buffer.cc @@ -1,11 +1,4 @@ -#if (__GNUC__ >= 8) && !defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wcast-function-type" -#endif #include "v8.h" -#if (__GNUC__ >= 8) && !defined(__clang__) -#pragma GCC diagnostic pop -#endif #include "aliased_buffer.h" #include "node_test_fixture.h"