diff --git a/src/node.cc b/src/node.cc index 1982156c7ae0c4..321c7088ac07e5 100644 --- a/src/node.cc +++ b/src/node.cc @@ -112,8 +112,6 @@ namespace node { using native_module::NativeModuleEnv; -using options_parser::kAllowedInEnvironment; -using options_parser::kDisallowedInEnvironment; using v8::Boolean; using v8::EscapableHandleScope; @@ -631,7 +629,7 @@ void ResetStdio() { int ProcessGlobalArgs(std::vector* args, std::vector* exec_args, std::vector* errors, - bool is_env) { + OptionEnvvarSettings settings) { // Parse a few arguments which are specific to Node. std::vector v8_args; @@ -641,7 +639,7 @@ int ProcessGlobalArgs(std::vector* args, exec_args, &v8_args, per_process::cli_options.get(), - is_env ? kAllowedInEnvironment : kDisallowedInEnvironment, + settings, errors); if (!errors->empty()) return 9; @@ -803,12 +801,18 @@ int InitializeNodeWithArgs(std::vector* argv, return 9; } - const int exit_code = ProcessGlobalArgs(&env_argv, nullptr, errors, true); + const int exit_code = ProcessGlobalArgs(&env_argv, + nullptr, + errors, + kAllowedInEnvironment); if (exit_code != 0) return exit_code; } #endif - const int exit_code = ProcessGlobalArgs(argv, exec_argv, errors, false); + const int exit_code = ProcessGlobalArgs(argv, + exec_argv, + errors, + kDisallowedInEnvironment); if (exit_code != 0) return exit_code; // Set the process.title immediately after processing argv if --title is set. diff --git a/src/node.h b/src/node.h index bc55abb145d29c..782d22412ec69a 100644 --- a/src/node.h +++ b/src/node.h @@ -219,6 +219,16 @@ NODE_EXTERN void Init(int* argc, int* exec_argc, const char*** exec_argv); +enum OptionEnvvarSettings { + kAllowedInEnvironment, + kDisallowedInEnvironment +}; + +NODE_EXTERN int ProcessGlobalArgs(std::vector* args, + std::vector* exec_args, + std::vector* errors, + OptionEnvvarSettings settings); + class NodeArrayBufferAllocator; // An ArrayBuffer::Allocator class with some Node.js-specific tweaks. If you do diff --git a/src/node_options.h b/src/node_options.h index 44b73fc1602031..719ba666419318 100644 --- a/src/node_options.h +++ b/src/node_options.h @@ -251,11 +251,6 @@ HostPort SplitHostPort(const std::string& arg, std::vector* errors); void GetOptions(const v8::FunctionCallbackInfo& args); -enum OptionEnvvarSettings { - kAllowedInEnvironment, - kDisallowedInEnvironment -}; - enum OptionType { kNoOp, kV8Option, diff --git a/src/node_worker.cc b/src/node_worker.cc index 9f2da4c9de2d19..f1b2347d29cbe3 100644 --- a/src/node_worker.cc +++ b/src/node_worker.cc @@ -16,7 +16,7 @@ #include #include -using node::options_parser::kDisallowedInEnvironment; +using node::kDisallowedInEnvironment; using v8::Array; using v8::ArrayBuffer; using v8::Boolean;