Skip to content

Commit

Permalink
lib: do not call callback if socket is closed
Browse files Browse the repository at this point in the history
PR-URL: #52829
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
theanarkh authored and targos committed Jun 1, 2024
1 parent 9f764a8 commit 040be4a
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 1 deletion.
5 changes: 4 additions & 1 deletion lib/dgram.js
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,10 @@ function bindServerHandle(self, options, errCb) {
const state = self[kStateSymbol];
cluster._getServer(self, options, (err, handle) => {
if (err) {
errCb(err);
// Do not call callback if socket is closed
if (state.handle) {
errCb(err);
}
return;
}

Expand Down
18 changes: 18 additions & 0 deletions test/parallel/test-dgram-bind-socket-close-before-cluster-reply.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
'use strict';
const common = require('../common');
const dgram = require('dgram');
const cluster = require('cluster');

if (cluster.isPrimary) {
cluster.fork();
} else {
// When the socket attempts to bind, it requests a handle from the cluster.
// Force the cluster to send back an error code.
const socket = dgram.createSocket('udp4');
cluster._getServer = function(self, options, callback) {
socket.close(() => { cluster.worker.disconnect(); });
callback(-1);
};
socket.on('error', common.mustNotCall());
socket.bind();
}

0 comments on commit 040be4a

Please sign in to comment.