Skip to content

Commit

Permalink
build: make build-addons errors fail the build
Browse files Browse the repository at this point in the history
The `build-addons` makefile target runs `tools/doc/addon-verify.js` and
then uses `touch` to update a timestamp file. Unconditionally calling
`touch` was losing the exit code from `tools/doc/addon-verify.js` so
any errors produced by that script were not failing the build.

PR-URL: #38983
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
richardlau committed Jul 20, 2021
1 parent 443db64 commit 069cf59
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ test/addons/.docbuildstamp: $(DOCBUILDSTAMP_PREREQS) tools/doc/node_modules
else \
$(RM) -r test/addons/??_*/; \
[ -x $(NODE) ] && $(NODE) $< || node $< ; \
touch $@; \
[ $$? -eq 0 ] && touch $@; \
fi

ADDONS_BINDING_GYPS := \
Expand Down

0 comments on commit 069cf59

Please sign in to comment.