From 085bb3abe5265ed1a01c27283478cb1fc9abdaa4 Mon Sep 17 00:00:00 2001 From: Dimitris Halatsis Date: Sun, 10 Jan 2021 18:35:12 +0200 Subject: [PATCH] test: http complete response after socket double end --- test/parallel/test-http-outgoing-end-cork.js | 91 ++++++++++++++++++++ 1 file changed, 91 insertions(+) create mode 100644 test/parallel/test-http-outgoing-end-cork.js diff --git a/test/parallel/test-http-outgoing-end-cork.js b/test/parallel/test-http-outgoing-end-cork.js new file mode 100644 index 00000000000000..271894292237c8 --- /dev/null +++ b/test/parallel/test-http-outgoing-end-cork.js @@ -0,0 +1,91 @@ +'use strict'; +const common = require('../common'); +const assert = require('assert'); +const http = require('http'); + +const REQ_TIMEOUT = 500; // set max ms of request time before abort + +// set total allowed test timeout to avoid infinite loop that will hang test suite +const TOTAL_TEST_TIMEOUT = 1000; + +// Placeholder for sockets handled, to make sure that we will reach a socket re-use case +const handledSockets = new Set(); + +let metReusedSocket = false; // flag for request loop termination + +const doubleEndResponse = (res) => { + // first end the request while sending some normal data + res.end('regular end of request', 'utf8', common.mustCall()); + // make sure the response socket is uncorked after first call of end + assert.strictEqual(res.writableCorked, 0); + res.end(); // double end the response to prep for next socket re-use +}; + +const sendDrainNeedingData = (res) => { + // send data to socket more than the high watermark so that it definitely needs drain + const highWaterMark = res.socket.writableHighWaterMark; + const bufferToSend = Buffer.alloc(highWaterMark + 100); + const ret = res.write(bufferToSend); // write the request data + assert.strictEqual(ret, false); // make sure that we had back pressure on response stream + res.once('drain', () => res.end()); // end on drain +}; + +const server = http.createServer((req, res) => { + const { socket: responseSocket } = res; + if (handledSockets.has(responseSocket)) { // re-used socket, send big data! + metReusedSocket = true; // stop request loop + console.debug('FOUND REUSED SOCKET!'); + sendDrainNeedingData(res); + } else { // not used again + // add to make sure we recognise it when we meet socket again + handledSockets.add(responseSocket); + doubleEndResponse(res); + } +}); + +server.listen(0); // start the server on a random port + +const sendRequest = (agent) => new Promise((resolve, reject) => { + const timeout = setTimeout(common.mustNotCall(() => { + reject(new Error('Request timed out')); + }), REQ_TIMEOUT); + http.get({ + port: server.address().port, + path: '/', + agent + }, common.mustCall((res) => { + const resData = []; + res.on('data', (data) => resData.push(data)); + res.on('end', common.mustCall(() => { + const totalData = resData.reduce((total, elem) => total + elem.length,0); + clearTimeout(timeout); // cancel rejection timeout + resolve(totalData); // fulfill promise + })); + })); +}); + +server.once('listening', async () => { + const testTimeout = setTimeout(common.mustNotCall(() => { + console.error('Test running for a while but could not met re-used socket'); + process.exit(1); + }), TOTAL_TEST_TIMEOUT); + // explicitly start agent to force socket reuse + const agent = new http.Agent({ keepAlive: true }); + // start the request loop + let reqNo = 0; + while(!metReusedSocket) { + try { + console.log(`Sending req no ${++reqNo}`); + const totalData = await sendRequest(agent); + console.log(`${totalData} bytes were received for request ${reqNo}`); + } catch (err) { + console.error(err); + process.exit(1); + } + } + // successfully tested conditions and ended loop + clearTimeout(testTimeout); + console.log('Closing server'); + agent.destroy(); + server.close(); +});