From 0b302e452096505a0ca73024fcf64fb56781c28e Mon Sep 17 00:00:00 2001 From: Robin Neatherway Date: Wed, 30 Jan 2019 12:55:54 -0500 Subject: [PATCH] lib: fix a few minor issues flagged by lgtm * Confusing (but correct) regex using `A-z` character range by accident * Add the status argument to afterShutdown PR-URL: https://github.com/nodejs/node/pull/25873 Reviewed-By: Refael Ackermann Reviewed-By: Anna Henningsen Reviewed-By: Sam Roberts --- lib/internal/http2/core.js | 3 ++- tools/cpplint.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js index fc99b50eae21f2..aa7682be4daf46 100644 --- a/lib/internal/http2/core.js +++ b/lib/internal/http2/core.js @@ -1518,7 +1518,8 @@ function streamOnPause() { this[kHandle].readStop(); } -function afterShutdown() { +function afterShutdown(status) { + // Currently this status value is unused this.callback(); const stream = this.handle[kOwner]; if (stream) diff --git a/tools/cpplint.py b/tools/cpplint.py index 17f341a61d7a2c..bae270747670be 100755 --- a/tools/cpplint.py +++ b/tools/cpplint.py @@ -636,7 +636,7 @@ def GetNonHeaderExtensions(): _RIGHT_LEANING_POINTER_PATTERN = re.compile(r'[^=|(,\s><);&?:}]' r'(?