From 1482c4415f8c862bccdbf506ed850da383087cb2 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 21 Nov 2021 21:01:56 -0800 Subject: [PATCH] build: fix `make` invocation in tools.yml Be in the correct directory for `make lint-md-rollup`. PR-URL: https://github.com/nodejs/node/pull/40890 Refs: https://github.com/nodejs/node/runs/4270533399?check_suite_focus=true Reviewed-By: Darshan Sen Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel --- .github/workflows/tools.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tools.yml b/.github/workflows/tools.yml index e77ddfe60ac8c0..9d0f07717ae0da 100644 --- a/.github/workflows/tools.yml +++ b/.github/workflows/tools.yml @@ -35,10 +35,17 @@ jobs: - id: "lint-md dependencies" run: | cd tools/lint-md - NEW_VERSION=$(npm outdated --omit=dev --parseable | cut -d: -f4 | xargs) + npm ci + NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs) if [ "$NEW_VERSION" != "" ]; then echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV - rm -rf package-lock.json node_modules && npm install --ignore-scripts + rm -rf package-lock.json node_modules + # Include $NEW_VERSION to explicitly update the package.json + # entry for the dependency and also so that semver-major updates + # are not skipped. + npm install --ignore-scripts $NEW_VERSION + npm install --ignore-scripts + cd ../.. make lint-md-rollup fi steps: