From 14c3af7f3e0eef24b6df43e05c97c8dd515f578e Mon Sep 17 00:00:00 2001
From: Anna Henningsen <anna@addaleax.net>
Date: Mon, 18 Mar 2019 13:30:21 +0100
Subject: [PATCH] src: only open HandleScope when necessary

PR-URL: https://github.com/nodejs/node/pull/26734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
---
 src/api/callback.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/api/callback.cc b/src/api/callback.cc
index b90f5ca92daf09..47a1549e93d943 100644
--- a/src/api/callback.cc
+++ b/src/api/callback.cc
@@ -79,7 +79,6 @@ InternalCallbackScope::~InternalCallbackScope() {
 void InternalCallbackScope::Close() {
   if (closed_) return;
   closed_ = true;
-  HandleScope handle_scope(env_->isolate());
 
   if (!env_->can_call_into_js()) return;
   if (failed_ && !env_->is_main_thread() && env_->is_stopping()) {
@@ -117,6 +116,7 @@ void InternalCallbackScope::Close() {
     return;
   }
 
+  HandleScope handle_scope(env_->isolate());
   Local<Object> process = env_->process_object();
 
   if (!env_->can_call_into_js()) return;