Skip to content

Commit

Permalink
test: make exported method static
Browse files Browse the repository at this point in the history
The exported method can be static as it will never be called directly.

PR-URL: #29102
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
rpoisel authored and targos committed Aug 19, 2019
1 parent a17d398 commit 18b7113
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/addons/hello-world/binding.cc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include <node.h>
#include <v8.h>

void Method(const v8::FunctionCallbackInfo<v8::Value>& args) {
static void Method(const v8::FunctionCallbackInfo<v8::Value>& args) {
v8::Isolate* isolate = args.GetIsolate();
args.GetReturnValue().Set(v8::String::NewFromUtf8(
isolate, "world", v8::NewStringType::kNormal).ToLocalChecked());
Expand Down

0 comments on commit 18b7113

Please sign in to comment.