From 18b711366af750a8196943028bb2457605d9234c Mon Sep 17 00:00:00 2001 From: Rainer Poisel Date: Tue, 13 Aug 2019 00:12:16 +0200 Subject: [PATCH] test: make exported method static The exported method can be static as it will never be called directly. PR-URL: https://github.com/nodejs/node/pull/29102 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Rich Trott --- test/addons/hello-world/binding.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/addons/hello-world/binding.cc b/test/addons/hello-world/binding.cc index 81bcbc29c78645..f2d26b53e985cf 100644 --- a/test/addons/hello-world/binding.cc +++ b/test/addons/hello-world/binding.cc @@ -1,7 +1,7 @@ #include #include -void Method(const v8::FunctionCallbackInfo& args) { +static void Method(const v8::FunctionCallbackInfo& args) { v8::Isolate* isolate = args.GetIsolate(); args.GetReturnValue().Set(v8::String::NewFromUtf8( isolate, "world", v8::NewStringType::kNormal).ToLocalChecked());