Skip to content

Commit

Permalink
test: add string-decoder fuzz test
Browse files Browse the repository at this point in the history
PR-URL: #22709
Fixes: #22626
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
addaleax committed Sep 24, 2018
1 parent 06f6ac1 commit 1b27428
Showing 1 changed file with 48 additions and 0 deletions.
48 changes: 48 additions & 0 deletions test/parallel/test-string-decoder-fuzz.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
'use strict';
require('../common');
const { StringDecoder } = require('string_decoder');
const util = require('util');
const assert = require('assert');

// Tests that, for random sequences of bytes, our StringDecoder gives the
// same result as a direction conversion using Buffer.toString().
// In particular, it checks that StringDecoder aligns with V8’s own output.

function rand(max) {
return Math.floor(Math.random() * max);
}

function randBuf(maxLen) {
const buf = Buffer.allocUnsafe(rand(maxLen));
for (let i = 0; i < buf.length; i++)
buf[i] = rand(256);
return buf;
}

const encodings = [
'utf16le', 'utf8', 'ascii', 'hex', 'base64', 'latin1'
];

function runSingleFuzzTest() {
const enc = encodings[rand(encodings.length)];
const sd = new StringDecoder(enc);
const bufs = [];
const strings = [];

const N = rand(10);
for (let i = 0; i < N; ++i) {
const buf = randBuf(50);
bufs.push(buf);
strings.push(sd.write(buf));
}
strings.push(sd.end());

assert.strictEqual(strings.join(''), Buffer.concat(bufs).toString(enc),
`Mismatch:\n${util.inspect(strings)}\n` +
util.inspect(bufs.map((buf) => buf.toString('hex'))) +
`\nfor encoding ${enc}`);
}

const start = Date.now();
while (Date.now() - start < 100)
runSingleFuzzTest();

0 comments on commit 1b27428

Please sign in to comment.