Skip to content

Commit

Permalink
doc: fix author-ready conflict
Browse files Browse the repository at this point in the history
The onboarding docs still contained an outdated description of the
`author-ready` label. Now it references the main description to
prevent any future conflicts.

PR-URL: #25015
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
BridgeAR authored and BethGriggs committed Dec 17, 2018
1 parent d366676 commit 1e09629
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions doc/onboarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,7 @@ onboarding session.
`semver-major` label
* When adding a `semver-*` label, add a comment explaining why you're adding
it. Do it right away so you don't forget!
* Please add the `author-ready` label for PRs where:
* the CI has been started (not necessarily finished),
* no outstanding review comments exist and
* at least two Collaborators approved the PR (one Collaborator approval is
enough if the pull request has been open for more than 7 days).
* Please add the [`author-ready`][] label for PRs, if applicable.

* See [Who to CC in the issue tracker][who-to-cc].
* This will come more naturally over time
Expand Down Expand Up @@ -245,6 +241,7 @@ needs to be pointed out separately during the onboarding.
the [summit](https://github.com/nodejs/summit) repository for details.

[Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
[`author-ready`]: https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#author-ready-pull-requests
[`core-validate-commit`]: https://github.com/nodejs/core-validate-commit
[`git-node`]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md
[`node-core-utils`]: https://github.com/nodejs/node-core-utils
Expand Down

0 comments on commit 1e09629

Please sign in to comment.