From 1e096291d6c8085ce389fe84ada326ee33814b27 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Thu, 13 Dec 2018 15:36:42 +0100 Subject: [PATCH] doc: fix author-ready conflict The onboarding docs still contained an outdated description of the `author-ready` label. Now it references the main description to prevent any future conflicts. PR-URL: https://github.com/nodejs/node/pull/25015 Reviewed-By: Daijiro Wachi Reviewed-By: Luigi Pinca Reviewed-By: Rich Trott --- doc/onboarding.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index 133680a8cfb93a..5938803e531c95 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -96,11 +96,7 @@ onboarding session. `semver-major` label * When adding a `semver-*` label, add a comment explaining why you're adding it. Do it right away so you don't forget! - * Please add the `author-ready` label for PRs where: - * the CI has been started (not necessarily finished), - * no outstanding review comments exist and - * at least two Collaborators approved the PR (one Collaborator approval is - enough if the pull request has been open for more than 7 days). + * Please add the [`author-ready`][] label for PRs, if applicable. * See [Who to CC in the issue tracker][who-to-cc]. * This will come more naturally over time @@ -245,6 +241,7 @@ needs to be pointed out separately during the onboarding. the [summit](https://github.com/nodejs/summit) repository for details. [Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md +[`author-ready`]: https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#author-ready-pull-requests [`core-validate-commit`]: https://github.com/nodejs/core-validate-commit [`git-node`]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md [`node-core-utils`]: https://github.com/nodejs/node-core-utils