From 1f88ca34243142b79dd6a48dabd81280bbaedddf Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 21 Aug 2019 22:01:38 -0700 Subject: [PATCH] test: add `emitClose: true` tests for fs streams PR-URL: https://github.com/nodejs/node/pull/29212 Fixes: https://github.com/nodejs/node/issues/29177 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Trivikram Kamat --- .../test-fs-stream-destroy-emit-error.js | 27 +++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-fs-stream-destroy-emit-error.js b/test/parallel/test-fs-stream-destroy-emit-error.js index c0405ce5f154f0..c1db9547a8a158 100644 --- a/test/parallel/test-fs-stream-destroy-emit-error.js +++ b/test/parallel/test-fs-stream-destroy-emit-error.js @@ -6,8 +6,31 @@ const fs = require('fs'); const tmpdir = require('../common/tmpdir'); tmpdir.refresh(); -test(fs.createReadStream(__filename)); -test(fs.createWriteStream(`${tmpdir.path}/dummy`)); +{ + const stream = fs.createReadStream(__filename); + stream.on('close', common.mustNotCall()); + test(stream); +} + +{ + const stream = fs.createWriteStream(`${tmpdir.path}/dummy`); + stream.on('close', common.mustNotCall()); + test(stream); +} + +{ + const stream = fs.createReadStream(__filename, { emitClose: true }); + stream.on('close', common.mustCall()); + test(stream); +} + +{ + const stream = fs.createWriteStream(`${tmpdir.path}/dummy2`, + { emitClose: true }); + stream.on('close', common.mustCall()); + test(stream); +} + function test(stream) { const err = new Error('DESTROYED');