Skip to content

Commit

Permalink
test: added net.connect lookup type check
Browse files Browse the repository at this point in the history
Check the options passed to Socket.prototype.connect() to
validate the type of the lookup property.

PR-URL: #11873
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
lucamaraschi authored and cjihrig committed Mar 20, 2017
1 parent 03a6c6e commit 1ff6796
Showing 1 changed file with 34 additions and 0 deletions.
34 changes: 34 additions & 0 deletions test/parallel/test-net-options-lookup.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const net = require('net');

const expectedError = /^TypeError: "lookup" option should be a function$/;

['foobar', 1, {}, []].forEach((input) => connectThrows(input));

function connectThrows(input) {
const opts = {
host: 'localhost',
port: common.PORT,
lookup: input
};

assert.throws(function() {
net.connect(opts);
}, expectedError);
}

[() => {}].forEach((input) => connectDoesNotThrow(input));

function connectDoesNotThrow(input) {
const opts = {
host: 'localhost',
port: common.PORT,
lookup: input
};

assert.doesNotThrow(function() {
net.connect(opts);
});
}

0 comments on commit 1ff6796

Please sign in to comment.