From 23cda7d9de14883a43b159cc922f66f818c6ccf7 Mon Sep 17 00:00:00 2001 From: Julien Gilli Date: Fri, 3 Feb 2017 19:57:25 +0000 Subject: [PATCH] test: fix test.py command line options processing https://github.com/nodejs/node/pull/11086 had introduced a regression that broke command line options processing for tools/test.py. Basically, it made tools/test.py discard the command line argument that would be passed after `--abort-on-timeout`. For instance, when running: ``` $ python tools/test.py --abort-on-timeout path/to/some-test ``` all tests would be run because the last command line argument (`/path/to/some-test`) would be discarded. This change fixes this regression. Refs: https://github.com/nodejs/node/pull/11086 PR-URL: https://github.com/nodejs/node/pull/11153 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen --- tools/test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/test.py b/tools/test.py index c900b1a83a88e0..f46b13fa30a66a 100755 --- a/tools/test.py +++ b/tools/test.py @@ -1399,7 +1399,7 @@ def BuildOptions(): default=1, type="int") result.add_option('--abort-on-timeout', help='Send SIGABRT instead of SIGTERM to kill processes that time out', - default=False, dest="abort_on_timeout") + default=False, action="store_true", dest="abort_on_timeout") return result