From 24c37423721cc9bad7e8b127e28c1dac9dd08e1c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
Date: Thu, 20 Jul 2023 15:20:44 +0200
Subject: [PATCH] test: delete test-net-bytes-per-incoming-chunk-overhead

The test's assumptions about RSS are no longer valid, at least with
Fedora 38.

Closes: https://github.com/nodejs/node/issues/48490
PR-URL: https://github.com/nodejs/node/pull/48811
Fixes: https://github.com/nodejs/node/issues/48490
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
---
 ...t-net-bytes-per-incoming-chunk-overhead.js | 50 -------------------
 1 file changed, 50 deletions(-)
 delete mode 100644 test/pummel/test-net-bytes-per-incoming-chunk-overhead.js

diff --git a/test/pummel/test-net-bytes-per-incoming-chunk-overhead.js b/test/pummel/test-net-bytes-per-incoming-chunk-overhead.js
deleted file mode 100644
index b3613110ab5c54..00000000000000
--- a/test/pummel/test-net-bytes-per-incoming-chunk-overhead.js
+++ /dev/null
@@ -1,50 +0,0 @@
-// Flags: --expose-gc
-'use strict';
-
-const common = require('../common');
-
-if (process.config.variables.asan) {
-  common.skip('ASAN messes with memory measurements');
-}
-
-if (common.isPi) {
-  common.skip('Too slow for Raspberry Pi devices');
-}
-
-const assert = require('assert');
-const net = require('net');
-
-// Tests that, when receiving small chunks, we do not keep the full length
-// of the original allocation for the libuv read call in memory.
-
-let client;
-let baseRSS;
-const receivedChunks = [];
-const N = 250000;
-
-const server = net.createServer(common.mustCall((socket) => {
-  baseRSS = process.memoryUsage.rss();
-
-  socket.setNoDelay(true);
-  socket.on('data', (chunk) => {
-    receivedChunks.push(chunk);
-    if (receivedChunks.length < N) {
-      client.write('a');
-    } else {
-      client.end();
-      server.close();
-    }
-  });
-})).listen(0, common.mustCall(() => {
-  client = net.connect(server.address().port);
-  client.setNoDelay(true);
-  client.write('hello!');
-}));
-
-process.on('exit', () => {
-  global.gc();
-  const bytesPerChunk =
-    (process.memoryUsage.rss() - baseRSS) / receivedChunks.length;
-  // We should always have less than one page (usually ~ 4 kB) per chunk.
-  assert(bytesPerChunk < 650, `measured ${bytesPerChunk} bytes per chunk`);
-});