Skip to content

Commit

Permalink
tools: fix compilation after V8 upgrade
Browse files Browse the repository at this point in the history
V8 now requires ICU's regular expressions.

PR-URL: #21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
targos committed Sep 7, 2018
1 parent 90ae4bd commit 267b0b5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tools/icu/icu-generic.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
'direct_dependent_settings': {
'defines': [
'UCONFIG_NO_SERVICE=1',
'UCONFIG_NO_REGULAR_EXPRESSIONS=1',
'U_ENABLE_DYLOAD=0',
'U_STATIC_IMPLEMENTATION=1',
'U_HAVE_STD_STRING=1',
Expand Down

0 comments on commit 267b0b5

Please sign in to comment.