-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: fix flaky test-child-process-spawnsync-input
Move portion of `test-child-process-spawnsync-input.js` (that has been flaky on CentOS in CI) to its own file. This allows us to more easily eliminate the cause of the flakiness without affecting other unrelated portions of the test. Fixes: #3863 PR-URL: #3889 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
Showing
2 changed files
with
27 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
'use strict'; | ||
require('../common'); | ||
const assert = require('assert'); | ||
|
||
const spawnSync = require('child_process').spawnSync; | ||
|
||
const msgOut = 'this is stdout'; | ||
|
||
// This is actually not os.EOL? | ||
const msgOutBuf = new Buffer(msgOut + '\n'); | ||
|
||
const args = [ | ||
'-e', | ||
`console.log("${msgOut}");` | ||
]; | ||
|
||
const options = { | ||
maxBuffer: 1 | ||
}; | ||
|
||
const ret = spawnSync(process.execPath, args, options); | ||
|
||
assert.ok(ret.error, 'maxBuffer should error'); | ||
assert.strictEqual(ret.error.errno, 'ENOBUFS'); | ||
// We can have buffers larger than maxBuffer because underneath we alloc 64k | ||
// that matches our read sizes | ||
assert.deepEqual(ret.stdout, msgOutBuf); |