Skip to content

Commit

Permalink
src: add missing 'inline' keywords
Browse files Browse the repository at this point in the history
The BaseObject constructor and destructor should not have external
linkage because BaseObject is a header-only construct.  Add the
necessary 'inline' keywords.

PR-URL: #6056
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
bnoordhuis authored and Myles Borins committed May 18, 2016
1 parent 6d56009 commit 2942cff
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/base-object.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ class Environment;

class BaseObject {
public:
BaseObject(Environment* env, v8::Local<v8::Object> handle);
virtual ~BaseObject();
inline BaseObject(Environment* env, v8::Local<v8::Object> handle);
inline virtual ~BaseObject();

// Returns the wrapped object. Returns an empty handle when
// persistent.IsEmpty() is true.
Expand Down

0 comments on commit 2942cff

Please sign in to comment.