From 2d575044ffd92b18910a731805c969671c4c9a5b Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Wed, 23 Jan 2019 13:04:02 +0100 Subject: [PATCH] src: fix compiler warnings in node_buffer.cc Currently the following compiler warnings are generated on Linux: ../src/node_buffer.cc: In function 'void node::Buffer::{anonymous}::StringSlice( const v8::FunctionCallbackInfo&) [with node::encoding encoding = (node::encoding)1]': ../src/node_buffer.cc:54:20: warning: 'start' may be used uninitialized in this function [-Wmaybe-uninitialized] if (end < start) end = start; ^~~ ../src/node_buffer.cc:50:10: note: 'start' was declared here size_t start; ^~~~~ This commit initializes start and end to zero to avoid these warnings. PR-URL: https://github.com/nodejs/node/pull/25665 Reviewed-By: Jeremiah Senkpiel Reviewed-By: Richard Lau Reviewed-By: Michael Dawson Reviewed-By: James M Snell --- src/node_buffer.cc | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/node_buffer.cc b/src/node_buffer.cc index e2ed994bb3e352..8e3745f2b465a7 100644 --- a/src/node_buffer.cc +++ b/src/node_buffer.cc @@ -47,8 +47,8 @@ } while (0) \ #define SLICE_START_END(env, start_arg, end_arg, end_max) \ - size_t start; \ - size_t end; \ + size_t start = 0; \ + size_t end = 0; \ THROW_AND_RETURN_IF_OOB(ParseArrayIndex(env, start_arg, 0, &start)); \ THROW_AND_RETURN_IF_OOB(ParseArrayIndex(env, end_arg, end_max, &end)); \ if (end < start) end = start; \ @@ -496,9 +496,9 @@ void Copy(const FunctionCallbackInfo &args) { SPREAD_BUFFER_ARG(buffer_obj, ts_obj); SPREAD_BUFFER_ARG(target_obj, target); - size_t target_start; - size_t source_start; - size_t source_end; + size_t target_start = 0; + size_t source_start = 0; + size_t source_end = 0; THROW_AND_RETURN_IF_OOB(ParseArrayIndex(env, args[2], 0, &target_start)); THROW_AND_RETURN_IF_OOB(ParseArrayIndex(env, args[3], 0, &source_start)); @@ -690,10 +690,10 @@ void CompareOffset(const FunctionCallbackInfo &args) { SPREAD_BUFFER_ARG(args[0], ts_obj); SPREAD_BUFFER_ARG(args[1], target); - size_t target_start; - size_t source_start; - size_t source_end; - size_t target_end; + size_t target_start = 0; + size_t source_start = 0; + size_t source_end = 0; + size_t target_end = 0; THROW_AND_RETURN_IF_OOB(ParseArrayIndex(env, args[2], 0, &target_start)); THROW_AND_RETURN_IF_OOB(ParseArrayIndex(env, args[3], 0, &source_start));