From 2f702f26b772e5cb6944e8cb01e26a372219a8bc Mon Sep 17 00:00:00 2001 From: Brian White Date: Tue, 20 Dec 2016 02:50:34 -0500 Subject: [PATCH] http: simplify boolean checks PR-URL: https://github.com/nodejs/node/pull/6533 Reviewed-By: Matteo Collina Reviewed-By: James M Snell Reviewed-By: Fedor Indutny Reviewed-By: Benjamin Gruenbaum --- lib/_http_outgoing.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js index 1e612316f4c7ee..262b1d9f87e4d8 100644 --- a/lib/_http_outgoing.js +++ b/lib/_http_outgoing.js @@ -239,7 +239,7 @@ function _storeHeader(firstLine, headers) { this.upgrading = true; // Date header - if (this.sendDate === true && state.sentDateHeader === false) { + if (this.sendDate && !state.sentDateHeader) { state.messageHeader += 'Date: ' + utcDate() + CRLF; } @@ -255,8 +255,7 @@ function _storeHeader(firstLine, headers) { // of creating security liabilities, so suppress the zero chunk and force // the connection to close. var statusCode = this.statusCode; - if ((statusCode === 204 || statusCode === 304) && - this.chunkedEncoding === true) { + if ((statusCode === 204 || statusCode === 304) && this.chunkedEncoding) { debug(statusCode + ' response should not use chunked encoding,' + ' closing connection.'); this.chunkedEncoding = false; @@ -267,7 +266,7 @@ function _storeHeader(firstLine, headers) { if (this._removedHeader.connection) { this._last = true; this.shouldKeepAlive = false; - } else if (state.sentConnectionHeader === false) { + } else if (!state.sentConnectionHeader) { var shouldSendKeepAlive = this.shouldKeepAlive && (state.sentContentLengthHeader || this.useChunkedEncodingByDefault || @@ -280,8 +279,7 @@ function _storeHeader(firstLine, headers) { } } - if (state.sentContentLengthHeader === false && - state.sentTransferEncodingHeader === false) { + if (!state.sentContentLengthHeader && !state.sentTransferEncodingHeader) { if (!this._hasBody) { // Make sure we don't end the 0\r\n\r\n at the end of the message. this.chunkedEncoding = false;