Skip to content

Commit

Permalink
test: update postmortem metadata test for V8 6.9
Browse files Browse the repository at this point in the history
The V8 6.9 update requires the following adjustments to the
postmortem debugging metadata constants:

- v8dbg_class_SharedFunctionInfo__function_identifier__Object
  Use: v8dbg_class_SharedFunctionInfo__function_identifier_or_debug_info__Object

- v8dbg_class_SharedFunctionInfo__end_position__int
  Use: v8dbg_class_UncompiledData__end_position__int32_t

- v8dbg_class_SharedFunctionInfo__start_position_and_type__int
  Use: v8dbg_class_UncompiledData__start_position__int32_t

- v8dbg_sharedfunctioninfo_start_position_mask and
- v8dbg_sharedfunctioninfo_start_position_shift
  Removed. Use: v8dbg_class_UncompiledData__start_position__int32_t

- v8dbg_scopeinfo_idx_nstacklocals has been removed

Refs: v8/v8@39e2d97
Refs: v8/v8@467eb14
Refs: v8/v8@c51bcd1

PR-URL: #21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
cjihrig authored and targos committed Sep 7, 2018
1 parent f7d572f commit 36cc812
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions test/v8-updates/test-postmortem-metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,12 @@ function getExpectedSymbols() {
'v8dbg_class_SeqTwoByteString__chars__char',
'v8dbg_class_SharedFunctionInfo__function_data__Object',
'v8dbg_class_SharedFunctionInfo__flags__int',
'v8dbg_class_SharedFunctionInfo__end_position__int',
'v8dbg_class_SharedFunctionInfo__function_identifier__Object',
'v8dbg_class_UncompiledData__end_position__int32_t',
'v8dbg_class_SharedFunctionInfo__function_identifier_or_debug_info__Object',
'v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t',
'v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object',
'v8dbg_class_SharedFunctionInfo__script__Object',
'v8dbg_class_SharedFunctionInfo__start_position_and_type__int',
'v8dbg_class_UncompiledData__start_position__int32_t',
'v8dbg_class_SlicedString__offset__SMI',
'v8dbg_class_SlicedString__parent__String',
'v8dbg_class_String__length__SMI',
Expand Down Expand Up @@ -150,9 +150,6 @@ function getExpectedSymbols() {
'v8dbg_scopeinfo_idx_first_vars',
'v8dbg_scopeinfo_idx_ncontextlocals',
'v8dbg_scopeinfo_idx_nparams',
'v8dbg_scopeinfo_idx_nstacklocals',
'v8dbg_sharedfunctioninfo_start_position_mask',
'v8dbg_sharedfunctioninfo_start_position_shift',
'v8dbg_type_Code__CODE_TYPE',
'v8dbg_type_FixedArray__FIXED_ARRAY_TYPE',
'v8dbg_type_HeapNumber__HEAP_NUMBER_TYPE',
Expand Down

0 comments on commit 36cc812

Please sign in to comment.