From 36cc812d18260dcfab416c6a8014b347d3865e12 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Tue, 7 Aug 2018 14:14:33 -0400 Subject: [PATCH] test: update postmortem metadata test for V8 6.9 The V8 6.9 update requires the following adjustments to the postmortem debugging metadata constants: - v8dbg_class_SharedFunctionInfo__function_identifier__Object Use: v8dbg_class_SharedFunctionInfo__function_identifier_or_debug_info__Object - v8dbg_class_SharedFunctionInfo__end_position__int Use: v8dbg_class_UncompiledData__end_position__int32_t - v8dbg_class_SharedFunctionInfo__start_position_and_type__int Use: v8dbg_class_UncompiledData__start_position__int32_t - v8dbg_sharedfunctioninfo_start_position_mask and - v8dbg_sharedfunctioninfo_start_position_shift Removed. Use: v8dbg_class_UncompiledData__start_position__int32_t - v8dbg_scopeinfo_idx_nstacklocals has been removed Refs: https://github.com/v8/v8/commit/39e2d97bc4d6b35be40294f06873f03b0368ce5c Refs: https://github.com/v8/v8/commit/467eb1497e998dd73a4006cf0655fd0ca289b6f4 Refs: https://github.com/v8/v8/commit/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5 PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By: Refael Ackermann Reviewed-By: Gus Caplan Reviewed-By: Ujjwal Sharma Reviewed-By: Matteo Collina --- test/v8-updates/test-postmortem-metadata.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/test/v8-updates/test-postmortem-metadata.js b/test/v8-updates/test-postmortem-metadata.js index f9fcc65a683788..626aaf3aea66c9 100644 --- a/test/v8-updates/test-postmortem-metadata.js +++ b/test/v8-updates/test-postmortem-metadata.js @@ -95,12 +95,12 @@ function getExpectedSymbols() { 'v8dbg_class_SeqTwoByteString__chars__char', 'v8dbg_class_SharedFunctionInfo__function_data__Object', 'v8dbg_class_SharedFunctionInfo__flags__int', - 'v8dbg_class_SharedFunctionInfo__end_position__int', - 'v8dbg_class_SharedFunctionInfo__function_identifier__Object', + 'v8dbg_class_UncompiledData__end_position__int32_t', + 'v8dbg_class_SharedFunctionInfo__function_identifier_or_debug_info__Object', 'v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t', 'v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object', 'v8dbg_class_SharedFunctionInfo__script__Object', - 'v8dbg_class_SharedFunctionInfo__start_position_and_type__int', + 'v8dbg_class_UncompiledData__start_position__int32_t', 'v8dbg_class_SlicedString__offset__SMI', 'v8dbg_class_SlicedString__parent__String', 'v8dbg_class_String__length__SMI', @@ -150,9 +150,6 @@ function getExpectedSymbols() { 'v8dbg_scopeinfo_idx_first_vars', 'v8dbg_scopeinfo_idx_ncontextlocals', 'v8dbg_scopeinfo_idx_nparams', - 'v8dbg_scopeinfo_idx_nstacklocals', - 'v8dbg_sharedfunctioninfo_start_position_mask', - 'v8dbg_sharedfunctioninfo_start_position_shift', 'v8dbg_type_Code__CODE_TYPE', 'v8dbg_type_FixedArray__FIXED_ARRAY_TYPE', 'v8dbg_type_HeapNumber__HEAP_NUMBER_TYPE',