From 3841999506177981407975f661a6ab8e46ce39c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Tue, 29 Oct 2019 08:28:28 +0100 Subject: [PATCH] tools: enable backtrace when V8 is built for PPC and S390 Refs: https://github.com/nodejs/node-v8/issues/119 --- common.gypi | 3 +++ tools/make-v8.sh | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index c9a512b265c40b..0617f978c28efc 100644 --- a/common.gypi +++ b/common.gypi @@ -105,6 +105,9 @@ 'obj_dir%': '<(PRODUCT_DIR)/obj.target', 'v8_base': '<(PRODUCT_DIR)/libv8_snapshot.a', }], + ['target_arch in ("ppc64", "s390x")', { + 'v8_enable_backtrace': 1, + }], ], }, diff --git a/tools/make-v8.sh b/tools/make-v8.sh index 1a6e175b6158cc..ed49051bfbb164 100755 --- a/tools/make-v8.sh +++ b/tools/make-v8.sh @@ -23,7 +23,7 @@ if [[ "$ARCH" == "s390x" ]]; then ln -s $CXX_PATH "$BUILD_TOOLS/gcc" g++ --version export PKG_CONFIG_PATH=$BUILD_TOOLS/pkg-config - gn gen -v out.gn/$BUILD_ARCH_TYPE --args='is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="s390x" target_cpu="s390x"' + gn gen -v out.gn/$BUILD_ARCH_TYPE --args='is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="s390x" target_cpu="s390x" v8_enable_backtrace=true' ninja -v -C out.gn/$BUILD_ARCH_TYPE d8 cctest inspector-test elif [[ "$ARCH" == "ppc64le" ]]; then if [[ X"$CXX" != X ]]; then @@ -32,7 +32,7 @@ elif [[ "$ARCH" == "ppc64le" ]]; then fi g++ --version export PKG_CONFIG_PATH=$BUILD_TOOLS/pkg-config-files - gn gen out.gn/$BUILD_ARCH_TYPE --args='is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="ppc64" target_cpu="ppc64"' + gn gen out.gn/$BUILD_ARCH_TYPE --args='is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="ppc64" target_cpu="ppc64" v8_enable_backtrace=true' ninja -C out.gn/$BUILD_ARCH_TYPE d8 cctest inspector-test else PATH=~/_depot_tools:$PATH tools/dev/v8gen.py $BUILD_ARCH_TYPE --no-goma $V8_BUILD_OPTIONS