From 3b2bbbdeca0b7265b4168cf390ad47f9b8b2f905 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Tue, 1 Oct 2019 21:58:12 +0200 Subject: [PATCH] src: allow unique_ptrs with custom deleter in memory tracker Originally landed in the QUIC repo Original review metadata: ``` PR-URL: https://github.com/nodejs/quic/pull/145 Reviewed-By: James M Snell ``` PR-URL: https://github.com/nodejs/node/pull/31870 Reviewed-By: Anna Henningsen Reviewed-By: David Carlier Reviewed-By: Joyee Cheung Reviewed-By: Denys Otrishko Reviewed-By: Colin Ihrig --- src/memory_tracker-inl.h | 4 ++-- src/memory_tracker.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/memory_tracker-inl.h b/src/memory_tracker-inl.h index da37f72c737607..bb91e8416610fd 100644 --- a/src/memory_tracker-inl.h +++ b/src/memory_tracker-inl.h @@ -99,9 +99,9 @@ void MemoryTracker::TrackField(const char* edge_name, } } -template +template void MemoryTracker::TrackField(const char* edge_name, - const std::unique_ptr& value, + const std::unique_ptr& value, const char* node_name) { if (value.get() == nullptr) { return; diff --git a/src/memory_tracker.h b/src/memory_tracker.h index d22116918afec8..e666190c416e72 100644 --- a/src/memory_tracker.h +++ b/src/memory_tracker.h @@ -134,9 +134,9 @@ class MemoryTracker { size_t size, const char* node_name = nullptr); // Shortcut to extract the underlying object out of the smart pointer - template + template inline void TrackField(const char* edge_name, - const std::unique_ptr& value, + const std::unique_ptr& value, const char* node_name = nullptr); // For containers, the elements will be graphed as grandchildren nodes