From 3b4bf94483cf2e99d7197cb50ffcda4a54f72c45 Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Thu, 16 Jan 2020 13:56:04 -0800 Subject: [PATCH] test: update postmortem test with v12 constants Ref: https://github.com/nodejs/llnode/pull/330 PR-URL: https://github.com/nodejs/node/pull/31391 Refs: https://github.com/nodejs/llnode/pull/330 Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Rich Trott --- test/v8-updates/test-postmortem-metadata.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/v8-updates/test-postmortem-metadata.js b/test/v8-updates/test-postmortem-metadata.js index 790d0dbb5c29b5..b7b830daf458d4 100644 --- a/test/v8-updates/test-postmortem-metadata.js +++ b/test/v8-updates/test-postmortem-metadata.js @@ -48,7 +48,8 @@ const missing = getExpectedSymbols().filter((symbol) => { return !symbols.includes(symbol); }); -assert.strictEqual(missing.length, 0, `Missing constants: ${missing}`); +assert.strictEqual(missing.length, 0, + `Missing constants: \n${missing.join('\n')}`); // This is only a function so that the long list of expected symbols can be // pushed to the bottom of the file for improved readability. @@ -58,6 +59,7 @@ function getExpectedSymbols() { // should only consist of postmortem constants, and some of them can be // relatively long. /* eslint-disable max-len */ + 'v8dbg_class_DescriptorArray__header_size__uintptr_t', 'v8dbg_bit_field3_is_dictionary_map_shift', 'v8dbg_bit_field3_number_of_own_descriptors_shift', 'v8dbg_class_Code__instruction_size__int',