Skip to content

Commit

Permalink
win,node-gyp: allow node.exe/iojs.exe to be renamed
Browse files Browse the repository at this point in the history
On Windows, when node or io.js attempts to dynamically load a compiled
addon, the compiled addon tries to load node.exe or iojs.exe again -
depending on which import library the module used when it was linked.
This makes it impossible to rename node.exe or iojs.exe, because when
that happens the module can't find its dependencies.

With this patch, a delay-load hook is added to all modules that are
compiled with node-gyp. The delay-load hook ensures that whenever a
module tries to load imports from node.exe/iojs.exe, it'll just refer
back to the process image, thus making it possible to rename the
iojs/node binary.

Bug: #751
Bug: #965
Upstream PR: nodejs/node-gyp#599

PR-URL: #1251
Reviewed-By: Rod Vagg <rod@vagg.org>
  • Loading branch information
piscisaureus committed Mar 25, 2015
1 parent c9207f7 commit 3d46fef
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 0 deletions.
12 changes: 12 additions & 0 deletions deps/npm/node_modules/node-gyp/addon.gypi

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 32 additions & 0 deletions deps/npm/node_modules/node-gyp/src/win_delay_load_hook.c

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3d46fef

Please sign in to comment.