From 3fffc7e95fa781cf57357691e78a94a6f05d0068 Mon Sep 17 00:00:00 2001 From: Shailesh Shekhawat Date: Wed, 27 Jun 2018 22:05:32 +0800 Subject: [PATCH] errors: fix undefined HTTP2 and tls errors Includes implementation of tls, HTTP2 error with documentation. PR-URL: https://github.com/nodejs/node/pull/21564 Refs: https://github.com/nodejs/node/issues/21440 Reviewed-By: Matteo Collina Reviewed-By: Anatoli Papirovski --- doc/api/errors.md | 10 ++++++++++ lib/internal/errors.js | 2 ++ 2 files changed, 12 insertions(+) diff --git a/doc/api/errors.md b/doc/api/errors.md index a122bc51e39ca6..be22aa1527727d 100644 --- a/doc/api/errors.md +++ b/doc/api/errors.md @@ -1014,6 +1014,11 @@ provided. The `Http2Session` closed with a non-zero error code. + +### ERR_HTTP2_SETTINGS_CANCEL + +The `Http2Session` settings canceled. + ### ERR_HTTP2_SOCKET_BOUND @@ -1629,6 +1634,11 @@ recommended to use 2048 bits or larger for stronger security. A TLS/SSL handshake timed out. In this case, the server must also abort the connection. + +### ERR_TLS_RENEGOTIATE + +An attempt to renegotiate the TLS session failed. + ### ERR_TLS_RENEGOTIATION_DISABLED diff --git a/lib/internal/errors.js b/lib/internal/errors.js index c3f1c374011b05..aef05489b48c74 100644 --- a/lib/internal/errors.js +++ b/lib/internal/errors.js @@ -585,6 +585,7 @@ E('ERR_HTTP2_SEND_FILE', 'Directories cannot be sent', Error); E('ERR_HTTP2_SEND_FILE_NOSEEK', 'Offset or length can only be specified for regular files', Error); E('ERR_HTTP2_SESSION_ERROR', 'Session closed with error code %s', Error); +E('ERR_HTTP2_SETTINGS_CANCEL', 'HTTP2 session settings canceled', Error); E('ERR_HTTP2_SOCKET_BOUND', 'The socket is already bound to an Http2Session', Error); E('ERR_HTTP2_STATUS_101', @@ -812,6 +813,7 @@ E('ERR_TLS_CERT_ALTNAME_INVALID', 'Hostname/IP does not match certificate\'s altnames: %s', Error); E('ERR_TLS_DH_PARAM_SIZE', 'DH parameter size %s is less than 2048', Error); E('ERR_TLS_HANDSHAKE_TIMEOUT', 'TLS handshake timeout', Error); +E('ERR_TLS_RENEGOTIATE', 'Attempt to renegotiate TLS session failed', Error); E('ERR_TLS_RENEGOTIATION_DISABLED', 'TLS session renegotiation disabled for this socket', Error);