From 40398fd07a8af6ef892cd493628a98379744a704 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 29 Jan 2019 14:41:33 -0800 Subject: [PATCH] benchmark: refactor _http-benchmarkers.js Refactor _http-benchmarkers.js: * The file used a mixture of inline callbacks with the `function` keyword and arrow functions. Use arrow functions for consistency. * The file used a mixture of trailing commas and no trailing commas. Use trailing commas for consistency. PR-URL: https://github.com/nodejs/node/pull/25803 Reviewed-By: James M Snell Reviewed-By: Luigi Pinca --- benchmark/_http-benchmarkers.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/benchmark/_http-benchmarkers.js b/benchmark/_http-benchmarkers.js index f66c36ab1d3d19..f4566284547ac4 100644 --- a/benchmark/_http-benchmarkers.js +++ b/benchmark/_http-benchmarkers.js @@ -25,7 +25,7 @@ class AutocannonBenchmarker { '-c', options.connections, '-j', '-n', - `http://127.0.0.1:${options.port}${options.path}` + `http://127.0.0.1:${options.port}${options.path}`, ]; const child = child_process.spawn(this.executable, args); return child; @@ -59,7 +59,7 @@ class WrkBenchmarker { '-d', options.duration, '-c', options.connections, '-t', 8, - `http://127.0.0.1:${options.port}${options.path}` + `http://127.0.0.1:${options.port}${options.path}`, ]; const child = child_process.spawn(this.executable, args); return child; @@ -170,7 +170,7 @@ const http_benchmarkers = [ new AutocannonBenchmarker(), new TestDoubleBenchmarker('http'), new TestDoubleBenchmarker('http2'), - new H2LoadBenchmarker() + new H2LoadBenchmarker(), ]; const benchmarkers = {}; @@ -188,7 +188,7 @@ exports.run = function(options, callback) { path: '/', connections: 100, duration: 5, - benchmarker: exports.default_http_benchmarker + benchmarker: exports.default_http_benchmarker, }, options); if (!options.benchmarker) { callback(new Error('Could not locate required http benchmarker. See ' + @@ -216,7 +216,7 @@ exports.run = function(options, callback) { let stdout = ''; child.stdout.on('data', (chunk) => stdout += chunk.toString()); - child.once('close', function(code) { + child.once('close', (code) => { const elapsed = process.hrtime(benchmarker_start); if (code) { let error_message = `${options.benchmarker} failed with ${code}.`;