Skip to content

Commit

Permalink
test: make test-fs-watchfile reliable
Browse files Browse the repository at this point in the history
Omitting AIX from `fs.watch()` portion of this test. It works
on AIX, but not reliably.

PR-URL: #13385
Fixes: #13377
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
Trott authored and jasnell committed Jun 5, 2017
1 parent 1b192f9 commit 406c2cd
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/parallel/test-fs-watchfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ fs.watchFile(enoentFile, {interval: 0}, common.mustCall(function(curr, prev) {
}
}, 2));

// Watch events should callback with a filename on supported systems
if (common.isLinux || common.isOSX || common.isWindows || common.isAix) {
// Watch events should callback with a filename on supported systems.
// Omitting AIX. It works but not reliably.
if (common.isLinux || common.isOSX || common.isWindows) {
const dir = common.tmpDir + '/watch';

fs.mkdir(dir, common.mustCall(function(err) {
Expand Down

0 comments on commit 406c2cd

Please sign in to comment.