From 4088d6e5420adff8abedc949457a991cbd087c66 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Tue, 27 Nov 2018 08:32:44 -0800 Subject: [PATCH] 2018-11-27, Version 10.13.1 'Dubnium' (LTS) Notable changes: * Coming Soon PR-URL: https://github.com/nodejs/node/pull/24675 --- CHANGELOG.md | 3 +- doc/changelogs/CHANGELOG_V10.md | 337 ++++++++++++++++++++++++++++++++ src/node_version.h | 4 +- 3 files changed, 341 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1339239e62c4f8..016970772e6feb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,7 +25,8 @@ release. -10.13.0
+10.13.1
+10.13.0
10.12.0
10.11.0
10.10.0
diff --git a/doc/changelogs/CHANGELOG_V10.md b/doc/changelogs/CHANGELOG_V10.md index 153f6eb46c9382..f46047f0cb2584 100644 --- a/doc/changelogs/CHANGELOG_V10.md +++ b/doc/changelogs/CHANGELOG_V10.md @@ -44,6 +44,343 @@ * [io.js](CHANGELOG_IOJS.md) * [Archive](CHANGELOG_ARCHIVE.md) + +## 2018-11-27, Version 10.13.1 'Dubnium' (LTS), @codebytere + +### Notable Changes + +Coming soon. + +### Commits + +* [[`8345a8227d`](https://github.com/nodejs/node/commit/8345a8227d)] - **async_hooks**: add missing async\_hooks destroys in AsyncReset (Bastian Krol) [#23272](https://github.com/nodejs/node/pull/23272) +* [[`9e92b8124d`](https://github.com/nodejs/node/commit/9e92b8124d)] - **benchmark**: fix bench-mkdirp to use recursive option (Klaus Meinhardt) [#23699](https://github.com/nodejs/node/pull/23699) +* [[`d13bb2c2eb`](https://github.com/nodejs/node/commit/d13bb2c2eb)] - **benchmark**: coerce PORT to number (Ali Ijaz Sheikh) [#23721](https://github.com/nodejs/node/pull/23721) +* [[`99d39f9cf0`](https://github.com/nodejs/node/commit/99d39f9cf0)] - **benchmark**: added a test benchmark for worker (Muzafar Umarov) [#23475](https://github.com/nodejs/node/pull/23475) +* [[`c39b910f6e`](https://github.com/nodejs/node/commit/c39b910f6e)] - **bootstrapper**: move internalBinding to NativeModule (Gus Caplan) [#23025](https://github.com/nodejs/node/pull/23025) +* [[`74f128a3cd`](https://github.com/nodejs/node/commit/74f128a3cd)] - **build**: make benchmark/napi all prereq order-only (Daniel Bevenius) [#23951](https://github.com/nodejs/node/pull/23951) +* [[`bd73da00f2`](https://github.com/nodejs/node/commit/bd73da00f2)] - **build**: add -Werror=undefined-inline to clang builds (Refael Ackermann) [#23961](https://github.com/nodejs/node/pull/23961) +* [[`51947a515d`](https://github.com/nodejs/node/commit/51947a515d)] - **build**: configure default v8\_optimized\_debug (Refael Ackermann) [#23704](https://github.com/nodejs/node/pull/23704) +* [[`aed45d7ce9`](https://github.com/nodejs/node/commit/aed45d7ce9)] - **build**: add lint-py which uses flake8 (cclauss) [#21952](https://github.com/nodejs/node/pull/21952) +* [[`9844188025`](https://github.com/nodejs/node/commit/9844188025)] - **build**: allow for overwriting of use\_openssl\_def (Shelley Vohr) [#23763](https://github.com/nodejs/node/pull/23763) +* [[`a5530159c1`](https://github.com/nodejs/node/commit/a5530159c1)] - **build**: fix coverage generation (Michael Dawson) [#23769](https://github.com/nodejs/node/pull/23769) +* [[`abd46ee1b5`](https://github.com/nodejs/node/commit/abd46ee1b5)] - **build**: fix `./configure --enable-d8` (Ben Noordhuis) [#23656](https://github.com/nodejs/node/pull/23656) +* [[`715768e1e1`](https://github.com/nodejs/node/commit/715768e1e1)] - **build**: add .DS\_store to .gitgnore (Marcos Frony) [#23554](https://github.com/nodejs/node/pull/23554) +* [[`8f58eed775`](https://github.com/nodejs/node/commit/8f58eed775)] - **build,meta**: switch to gcc-4.9 on travis (Refael Ackermann) [#23778](https://github.com/nodejs/node/pull/23778) +* [[`d1ac802989`](https://github.com/nodejs/node/commit/d1ac802989)] - **child_process**: handle undefined/null for fork() args (Shobhit Chittora) [#22416](https://github.com/nodejs/node/pull/22416) +* [[`d62d6666d4`](https://github.com/nodejs/node/commit/d62d6666d4)] - **crypto**: add SET\_INTEGER\_CONSANT macro (Daniel Bevenius) [#23687](https://github.com/nodejs/node/pull/23687) +* [[`cbc54d4f5d`](https://github.com/nodejs/node/commit/cbc54d4f5d)] - **crypto**: strip unwanted space from openssl version (Sam Roberts) [#23678](https://github.com/nodejs/node/pull/23678) +* [[`f216699ab4`](https://github.com/nodejs/node/commit/f216699ab4)] - **crypto**: remove DiffieHellman.initialised\_ (Tobias Nießen) [#23717](https://github.com/nodejs/node/pull/23717) +* [[`3ca41dce5c`](https://github.com/nodejs/node/commit/3ca41dce5c)] - **crypto**: simplify internal state handling (Tobias Nießen) [#23648](https://github.com/nodejs/node/pull/23648) +* [[`4ba897750d`](https://github.com/nodejs/node/commit/4ba897750d)] - **crypto**: simplify error handling in ECDH::New (Tobias Nießen) [#23647](https://github.com/nodejs/node/pull/23647) +* [[`86a5690e38`](https://github.com/nodejs/node/commit/86a5690e38)] - **crypto**: move field initialization to class (Diana Holland) [#23610](https://github.com/nodejs/node/pull/23610) +* [[`a3540914c9`](https://github.com/nodejs/node/commit/a3540914c9)] - **crypto**: fix length argument to snprintf() (Ben Noordhuis) [#23622](https://github.com/nodejs/node/pull/23622) +* [[`e66c09e459`](https://github.com/nodejs/node/commit/e66c09e459)] - **deps**: cherry-pick 2987946 from upstream V8 (Refael Ackermann) [#24555](https://github.com/nodejs/node/pull/24555) +* [[`b2fbefb037`](https://github.com/nodejs/node/commit/b2fbefb037)] - **deps**: icu: apply workaround patch (Steven R. Loomis) [#23764](https://github.com/nodejs/node/pull/23764) +* [[`20430ae487`](https://github.com/nodejs/node/commit/20430ae487)] - **deps**: V8: Add virtual dtor to avoid aix gcc error (Vasili Skurydzin) [#23695](https://github.com/nodejs/node/pull/23695) +* [[`d3fb599b61`](https://github.com/nodejs/node/commit/d3fb599b61)] - **deps**: cherry-pick 67b5499 from V8 upstream (Vasili Skurydzin) [#23695](https://github.com/nodejs/node/pull/23695) +* [[`f2d3bade81`](https://github.com/nodejs/node/commit/f2d3bade81)] - **deps**: cherry-pick d2e0166 from V8 upstream (Vasili Skurydzin) [#23695](https://github.com/nodejs/node/pull/23695) +* [[`a4d67c95b6`](https://github.com/nodejs/node/commit/a4d67c95b6)] - **deps**: cherry-pick a51f429 from V8 upstream (Vasili Skurydzin) [#23695](https://github.com/nodejs/node/pull/23695) +* [[`01544e1224`](https://github.com/nodejs/node/commit/01544e1224)] - **deps**: cherry-pick abab9fb from V8 upstream (Vasili Skurydzin) [#23695](https://github.com/nodejs/node/pull/23695) +* [[`d4c8d778e8`](https://github.com/nodejs/node/commit/d4c8d778e8)] - **deps**: cherry-pick d9e7832 from V8 upstream (Vasili Skurydzin) [#23695](https://github.com/nodejs/node/pull/23695) +* [[`1e9b4a2a09`](https://github.com/nodejs/node/commit/1e9b4a2a09)] - **deps**: backport 525b396195 from upstream V8 (Peter Marshall) [#23827](https://github.com/nodejs/node/pull/23827) +* [[`2290c315a2`](https://github.com/nodejs/node/commit/2290c315a2)] - **deps**: partially revert 'increase V8 deprecation levels' (Peter Marshall) [#24195](https://github.com/nodejs/node/pull/24195) +* [[`44279e03fc`](https://github.com/nodejs/node/commit/44279e03fc)] - **deps**: add missing ares\_android.h file (cjihrig) [#23682](https://github.com/nodejs/node/pull/23682) +* [[`67f5d3052d`](https://github.com/nodejs/node/commit/67f5d3052d)] - **deps,v8**: fix gypfile bug (Refael Ackermann) [#23704](https://github.com/nodejs/node/pull/23704) +* [[`b2252ea81d`](https://github.com/nodejs/node/commit/b2252ea81d)] - **dns**: fix inconsistent (hostname vs host) (Ulises Gascón) [#23572](https://github.com/nodejs/node/pull/23572) +* [[`a66d8774ac`](https://github.com/nodejs/node/commit/a66d8774ac)] - **doc**: fix dublication in net.createServer() docs (Ivan Filenko) [#24026](https://github.com/nodejs/node/pull/24026) +* [[`435e7b4673`](https://github.com/nodejs/node/commit/435e7b4673)] - **doc**: address bits of proof reading work (Jagannath Bhat) [#23978](https://github.com/nodejs/node/pull/23978) +* [[`514b537604`](https://github.com/nodejs/node/commit/514b537604)] - **doc**: revise COLLABORATOR\_GUIDE.md (Rich Trott) [#23990](https://github.com/nodejs/node/pull/23990) +* [[`8f782fbe27`](https://github.com/nodejs/node/commit/8f782fbe27)] - **doc**: simplify CODE\_OF\_CONDUCT.md (Rich Trott) [#23989](https://github.com/nodejs/node/pull/23989) +* [[`5c6d49b486`](https://github.com/nodejs/node/commit/5c6d49b486)] - **doc**: revise CHANGELOG.md text (Rich Trott) [#23988](https://github.com/nodejs/node/pull/23988) +* [[`17c2ddd71d`](https://github.com/nodejs/node/commit/17c2ddd71d)] - **doc**: improve COLLABORATOR\_GUIDE (Jagannath Bhat) [#23977](https://github.com/nodejs/node/pull/23977) +* [[`a9dcf6f0ce`](https://github.com/nodejs/node/commit/a9dcf6f0ce)] - **doc**: improve BUILDING.md (Jagannath Bhat) [#23976](https://github.com/nodejs/node/pull/23976) +* [[`a35e8f1666`](https://github.com/nodejs/node/commit/a35e8f1666)] - **doc**: add types and their corresponding return values (Ouyang Yadong) [#23998](https://github.com/nodejs/node/pull/23998) +* [[`4a52fc0fea`](https://github.com/nodejs/node/commit/4a52fc0fea)] - **doc**: add branding to style guide (Rich Trott) [#23967](https://github.com/nodejs/node/pull/23967) +* [[`803070b7f1`](https://github.com/nodejs/node/commit/803070b7f1)] - **doc**: use Node.js instead of Node (Rich Trott) [#23967](https://github.com/nodejs/node/pull/23967) +* [[`f6abca9d62`](https://github.com/nodejs/node/commit/f6abca9d62)] - **doc**: revise BUILDING.md (Rich Trott) [#23966](https://github.com/nodejs/node/pull/23966) +* [[`8180b0b5b3`](https://github.com/nodejs/node/commit/8180b0b5b3)] - **doc**: clarify fd behaviour with {read,write}File (Sakthipriyan Vairamani (thefourtheye)) [#23706](https://github.com/nodejs/node/pull/23706) +* [[`1c9ae77c40`](https://github.com/nodejs/node/commit/1c9ae77c40)] - **doc**: fix typographical issues (Denis McDonald) [#23970](https://github.com/nodejs/node/pull/23970) +* [[`d19a3d6ee3`](https://github.com/nodejs/node/commit/d19a3d6ee3)] - **doc**: document HPE\_HEADER\_OVERFLOW error (Sam Roberts) [#23963](https://github.com/nodejs/node/pull/23963) +* [[`3c46c03678`](https://github.com/nodejs/node/commit/3c46c03678)] - **doc**: add documentation for http.IncomingMessage$complete (James M Snell) [#23914](https://github.com/nodejs/node/pull/23914) +* [[`ddfb22fd96`](https://github.com/nodejs/node/commit/ddfb22fd96)] - **doc**: remove mailing list (Rich Trott) [#23932](https://github.com/nodejs/node/pull/23932) +* [[`5072fcb899`](https://github.com/nodejs/node/commit/5072fcb899)] - **doc**: remove notice of dashes in V8 options (Denys Otrishko) [#23903](https://github.com/nodejs/node/pull/23903) +* [[`839f026ded`](https://github.com/nodejs/node/commit/839f026ded)] - **doc**: rename README section for Release Keys (Rich Trott) [#23927](https://github.com/nodejs/node/pull/23927) +* [[`565f4ca950`](https://github.com/nodejs/node/commit/565f4ca950)] - **doc**: add note about ABI compatibility (Myles Borins) [#22237](https://github.com/nodejs/node/pull/22237) +* [[`64c683bcdc`](https://github.com/nodejs/node/commit/64c683bcdc)] - **doc**: add optional callback to socket.end() (Ajido) [#23937](https://github.com/nodejs/node/pull/23937) +* [[`c0649c83b3`](https://github.com/nodejs/node/commit/c0649c83b3)] - **doc**: make example more clarified in cluster.md (ZYSzys) [#23931](https://github.com/nodejs/node/pull/23931) +* [[`fa9d2861ed`](https://github.com/nodejs/node/commit/fa9d2861ed)] - **doc**: simplify valid security issue descriptions (Rich Trott) [#23881](https://github.com/nodejs/node/pull/23881) +* [[`28ee410c9d`](https://github.com/nodejs/node/commit/28ee410c9d)] - **doc**: simplify path.basename() on POSIX and Windows (ZYSzys) [#23864](https://github.com/nodejs/node/pull/23864) +* [[`09faedfcf5`](https://github.com/nodejs/node/commit/09faedfcf5)] - **doc**: document nullptr comparisons in style guide (Anna Henningsen) [#23805](https://github.com/nodejs/node/pull/23805) +* [[`9a09f8af90`](https://github.com/nodejs/node/commit/9a09f8af90)] - **doc**: remove problematic example from README (Rich Trott) [#23817](https://github.com/nodejs/node/pull/23817) +* [[`8a6086c682`](https://github.com/nodejs/node/commit/8a6086c682)] - **doc**: use Cookie in request.setHeader() examples (Luigi Pinca) [#23707](https://github.com/nodejs/node/pull/23707) +* [[`f5c68dc363`](https://github.com/nodejs/node/commit/f5c68dc363)] - **doc**: NODE\_EXTRA\_CA\_CERTS is ignored if setuid root (Ben Noordhuis) [#23770](https://github.com/nodejs/node/pull/23770) +* [[`e711e45191`](https://github.com/nodejs/node/commit/e711e45191)] - **doc**: add review suggestions to require() (erickwendel) [#23605](https://github.com/nodejs/node/pull/23605) +* [[`f1c2fb3ae2`](https://github.com/nodejs/node/commit/f1c2fb3ae2)] - **doc**: document and warn if the ICU version is too old (Steven R. Loomis) [#23766](https://github.com/nodejs/node/pull/23766) +* [[`c77d127dfe`](https://github.com/nodejs/node/commit/c77d127dfe)] - **doc**: move @phillipj to emeriti (Phillip Johnsen) [#23790](https://github.com/nodejs/node/pull/23790) +* [[`9982c09469`](https://github.com/nodejs/node/commit/9982c09469)] - **doc**: add note about removeListener order (James M Snell) [#23762](https://github.com/nodejs/node/pull/23762) +* [[`bd0e0d2105`](https://github.com/nodejs/node/commit/bd0e0d2105)] - **doc**: document ACL limitation for fs.access on Windows (James M Snell) [#23772](https://github.com/nodejs/node/pull/23772) +* [[`64f9a3c138`](https://github.com/nodejs/node/commit/64f9a3c138)] - **doc**: document that addMembership must be called once in a cluster (James M Snell) [#23746](https://github.com/nodejs/node/pull/23746) +* [[`30bcddcaeb`](https://github.com/nodejs/node/commit/30bcddcaeb)] - **doc**: add missing YAML labels (Vse Mozhet Byt) [#23810](https://github.com/nodejs/node/pull/23810) +* [[`f8bd7c0f02`](https://github.com/nodejs/node/commit/f8bd7c0f02)] - **doc**: remove reference to sslv3 in tls.md (James M Snell) [#23745](https://github.com/nodejs/node/pull/23745) +* [[`da65cb61e5`](https://github.com/nodejs/node/commit/da65cb61e5)] - **doc**: revise security-reporting example text (Rich Trott) [#23759](https://github.com/nodejs/node/pull/23759) +* [[`30b1a4a61f`](https://github.com/nodejs/node/commit/30b1a4a61f)] - **doc**: formalize non-const reference usage in C++ style guide (Anna Henningsen) [#23155](https://github.com/nodejs/node/pull/23155) +* [[`523db5f5a9`](https://github.com/nodejs/node/commit/523db5f5a9)] - **doc**: fix headings for CHANGELOG\_v10.md (Myles Borins) [#23973](https://github.com/nodejs/node/pull/23973) +* [[`4c9d993d8c`](https://github.com/nodejs/node/commit/4c9d993d8c)] - **doc**: add missing deprecation labels (James M Snell) [#23761](https://github.com/nodejs/node/pull/23761) +* [[`f318d163a5`](https://github.com/nodejs/node/commit/f318d163a5)] - **doc**: document use of buffer.swap16() for utf16be (James M Snell) [#23747](https://github.com/nodejs/node/pull/23747) +* [[`d862f1e894`](https://github.com/nodejs/node/commit/d862f1e894)] - **doc**: add Backport-PR-URL info in backport guide (Ali Ijaz Sheikh) [#23701](https://github.com/nodejs/node/pull/23701) +* [[`8cd83c50b8`](https://github.com/nodejs/node/commit/8cd83c50b8)] - **doc**: improve README.md (Rich Trott) [#23705](https://github.com/nodejs/node/pull/23705) +* [[`e856fa2155`](https://github.com/nodejs/node/commit/e856fa2155)] - **doc**: simplify security reporting text (Rich Trott) [#23686](https://github.com/nodejs/node/pull/23686) +* [[`3e4032a333`](https://github.com/nodejs/node/commit/3e4032a333)] - **doc**: cleanup and references in C++ guide (Refael Ackermann) [#23650](https://github.com/nodejs/node/pull/23650) +* [[`00c028fb1d`](https://github.com/nodejs/node/commit/00c028fb1d)] - **doc**: fix url example to match behavior (Сковорода Никита Андреевич) [#23359](https://github.com/nodejs/node/pull/23359) +* [[`272d4faadf`](https://github.com/nodejs/node/commit/272d4faadf)] - **doc**: use reserved domains for examples in url.md (Сковорода Никита Андреевич) [#23359](https://github.com/nodejs/node/pull/23359) +* [[`43d4977c96`](https://github.com/nodejs/node/commit/43d4977c96)] - **doc**: fix pr-url in repl.md (Сковорода Никита Андреевич) [#23359](https://github.com/nodejs/node/pull/23359) +* [[`5ee0d90b6e`](https://github.com/nodejs/node/commit/5ee0d90b6e)] - **doc**: wrap links in \<\> (Сковорода Никита Андреевич) [#23359](https://github.com/nodejs/node/pull/23359) +* [[`45fbcbb68d`](https://github.com/nodejs/node/commit/45fbcbb68d)] - **doc**: edit BUILDING.md (Rich Trott) [#23435](https://github.com/nodejs/node/pull/23435) +* [[`1266878cbe`](https://github.com/nodejs/node/commit/1266878cbe)] - **doc**: describe SNI host name format (Sam Roberts) [#23357](https://github.com/nodejs/node/pull/23357) +* [[`4e1a54f309`](https://github.com/nodejs/node/commit/4e1a54f309)] - **doc**: revise security-reporting text in README (Rich Trott) [#23407](https://github.com/nodejs/node/pull/23407) +* [[`39c59be38a`](https://github.com/nodejs/node/commit/39c59be38a)] - **doc**: rewrite consensus seeking in guide (Rich Trott) [#23349](https://github.com/nodejs/node/pull/23349) +* [[`f63bf3fe0e`](https://github.com/nodejs/node/commit/f63bf3fe0e)] - **doc**: edit for minor fixes to prcoess.md (Rich Trott) [#23347](https://github.com/nodejs/node/pull/23347) +* [[`6603592ab4`](https://github.com/nodejs/node/commit/6603592ab4)] - **doc**: remove personal pronoun from worker\_threads (Rich Trott) [#23347](https://github.com/nodejs/node/pull/23347) +* [[`ab90013836`](https://github.com/nodejs/node/commit/ab90013836)] - **doc**: remove personal pronoun from domain.md (Rich Trott) [#23347](https://github.com/nodejs/node/pull/23347) +* [[`1e119eb6ae`](https://github.com/nodejs/node/commit/1e119eb6ae)] - **doc**: remove style instruction that is not followed (Rich Trott) [#23346](https://github.com/nodejs/node/pull/23346) +* [[`6196884390`](https://github.com/nodejs/node/commit/6196884390)] - **doc**: add WebAssembly to globals (Steven) [#23339](https://github.com/nodejs/node/pull/23339) +* [[`26f4221fc0`](https://github.com/nodejs/node/commit/26f4221fc0)] - **doc,meta**: assign PR semantics (Refael Ackermann) [#23292](https://github.com/nodejs/node/pull/23292) +* [[`b7d6c1ae96`](https://github.com/nodejs/node/commit/b7d6c1ae96)] - **doc,meta**: refresh wording in colab guide (Refael Ackermann) [#23292](https://github.com/nodejs/node/pull/23292) +* [[`2f51e49570`](https://github.com/nodejs/node/commit/2f51e49570)] - **doc,meta**: add references to outside C++ guides (Refael Ackermann) [#23317](https://github.com/nodejs/node/pull/23317) +* [[`d4f0366a7d`](https://github.com/nodejs/node/commit/d4f0366a7d)] - **http**: reduce duplicated code for cleaning parser (Weijia Wang) [#23351](https://github.com/nodejs/node/pull/23351) +* [[`9f4be5d1cb`](https://github.com/nodejs/node/commit/9f4be5d1cb)] - **http2**: make Http2Settings constructors delegate (Daniel Bevenius) [#23326](https://github.com/nodejs/node/pull/23326) +* [[`7374c0c5e1`](https://github.com/nodejs/node/commit/7374c0c5e1)] - **lib**: fix code cache generation (Joyee Cheung) [#23855](https://github.com/nodejs/node/pull/23855) +* [[`dd82014f60`](https://github.com/nodejs/node/commit/dd82014f60)] - **lib**: remove useless cwd in posix.resolve (ZYSzys) [#23902](https://github.com/nodejs/node/pull/23902) +* [[`c601fdef12`](https://github.com/nodejs/node/commit/c601fdef12)] - **lib**: migrate from process.binding('config') to getOptions() (Vladimir Ilic) [#23588](https://github.com/nodejs/node/pull/23588) +* [[`9b89e9c250`](https://github.com/nodejs/node/commit/9b89e9c250)] - **lib**: migrate process.binding to internalBinding (surreal8) [#23517](https://github.com/nodejs/node/pull/23517) +* [[`100ed74216`](https://github.com/nodejs/node/commit/100ed74216)] - **lib**: migrate process.binding to getOptions (Randy Wressell) [#23522](https://github.com/nodejs/node/pull/23522) +* [[`6eea5dc6e8`](https://github.com/nodejs/node/commit/6eea5dc6e8)] - **lib**: migrate process.binding('config') to getOptions() (Jonny Kalambay) [#23526](https://github.com/nodejs/node/pull/23526) +* [[`5a0b9faab8`](https://github.com/nodejs/node/commit/5a0b9faab8)] - **lib**: removed unused variable (Long Nguyen) [#23497](https://github.com/nodejs/node/pull/23497) +* [[`c634698d5c`](https://github.com/nodejs/node/commit/c634698d5c)] - **lib**: switch to internalBinding for cjs loader (Steven Scott) [#23492](https://github.com/nodejs/node/pull/23492) +* [[`26f356f7ab`](https://github.com/nodejs/node/commit/26f356f7ab)] - **lib**: migrate from process.binding to internalBinding (Andres Monge) [#23586](https://github.com/nodejs/node/pull/23586) +* [[`6acc89172f`](https://github.com/nodejs/node/commit/6acc89172f)] - **lib**: migrate to getOptions in loaders.js (David Xue) [#23455](https://github.com/nodejs/node/pull/23455) +* [[`00698cc4e5`](https://github.com/nodejs/node/commit/00698cc4e5)] - **lib**: remove an unused variable (Claire Liu) [#23482](https://github.com/nodejs/node/pull/23482) +* [[`63988f6cfd`](https://github.com/nodejs/node/commit/63988f6cfd)] - **lib**: remove unused 'e' from catch (Matt Holmes) [#23458](https://github.com/nodejs/node/pull/23458) +* [[`8016d35ea3`](https://github.com/nodejs/node/commit/8016d35ea3)] - **lib**: http server, friendly error messages (Sagi Tsofan) [#22995](https://github.com/nodejs/node/pull/22995) +* [[`8ec2c51bc9`](https://github.com/nodejs/node/commit/8ec2c51bc9)] - **meta**: clarify fast-track approval (James M Snell) [#23744](https://github.com/nodejs/node/pull/23744) +* [[`4f8e4f065c`](https://github.com/nodejs/node/commit/4f8e4f065c)] - **module**: removed unused variable (Martin Omander) [#23624](https://github.com/nodejs/node/pull/23624) +* [[`9b951601e2`](https://github.com/nodejs/node/commit/9b951601e2)] - **n-api**: make per-`Context`-ness of `napi\_env` explicit (Anna Henningsen) [#23689](https://github.com/nodejs/node/pull/23689) +* [[`ac73050fc8`](https://github.com/nodejs/node/commit/ac73050fc8)] - **os**: fix memory leak in `userInfo()` (Anna Henningsen) [#23893](https://github.com/nodejs/node/pull/23893) +* [[`5e1b9c3c91`](https://github.com/nodejs/node/commit/5e1b9c3c91)] - **readline**: assert without the use of event listener (Lian Li) [#23472](https://github.com/nodejs/node/pull/23472) +* [[`d1c0827294`](https://github.com/nodejs/node/commit/d1c0827294)] - **repl**: migrate from process.binding('config') to getOptions() (Jose Bucio) [#23684](https://github.com/nodejs/node/pull/23684) +* [[`9dfc13efa0`](https://github.com/nodejs/node/commit/9dfc13efa0)] - **repl**: remove unused variable from try catch (mmisiarek) [#23452](https://github.com/nodejs/node/pull/23452) +* [[`18060f2d12`](https://github.com/nodejs/node/commit/18060f2d12)] - **repl**: remove unused variable e from try catch (Khalid Adil) [#23449](https://github.com/nodejs/node/pull/23449) +* [[`d25e94b795`](https://github.com/nodejs/node/commit/d25e94b795)] - **src**: fix fully-static & large-pages combination (Suresh Srinivas) [#23964](https://github.com/nodejs/node/pull/23964) +* [[`592f5bd49c`](https://github.com/nodejs/node/commit/592f5bd49c)] - **src**: use "constants" string instead of creating new one (Ouyang Yadong) [#23894](https://github.com/nodejs/node/pull/23894) +* [[`98649dc17f`](https://github.com/nodejs/node/commit/98649dc17f)] - **src**: reduce duplication in tcp\_wrap Connect (Daniel Bevenius) [#23753](https://github.com/nodejs/node/pull/23753) +* [[`d316f64e9e`](https://github.com/nodejs/node/commit/d316f64e9e)] - **src**: refactor deprecated v8::String::NewFromTwoByte call (Romain Lanz) [#23803](https://github.com/nodejs/node/pull/23803) +* [[`2e3e68aac1`](https://github.com/nodejs/node/commit/2e3e68aac1)] - **src**: refactor deprecated v8::Function::Call call (Romain Lanz) [#23804](https://github.com/nodejs/node/pull/23804) +* [[`9a7554a85b`](https://github.com/nodejs/node/commit/9a7554a85b)] - **src**: fix CreatePlatform header param mismatch (Shelley Vohr) [#23947](https://github.com/nodejs/node/pull/23947) +* [[`de2340dccd`](https://github.com/nodejs/node/commit/de2340dccd)] - **src**: trace\_event: secondary storage for metadata (Ali Ijaz Sheikh) [#20900](https://github.com/nodejs/node/pull/20900) +* [[`d1102f81dc`](https://github.com/nodejs/node/commit/d1102f81dc)] - **src**: initial large page (2M) support (Suresh Srinivas) [#22079](https://github.com/nodejs/node/pull/22079) +* [[`850b54f4fd`](https://github.com/nodejs/node/commit/850b54f4fd)] - **src**: changed stdio\_pipes\_ to std::vector (Steven Auger) [#23615](https://github.com/nodejs/node/pull/23615) +* [[`f5cadf6c12`](https://github.com/nodejs/node/commit/f5cadf6c12)] - **src**: update v8::Object::GetPropertyNames() usage (cjihrig) [#23660](https://github.com/nodejs/node/pull/23660) +* [[`ea9c44d6f8`](https://github.com/nodejs/node/commit/ea9c44d6f8)] - **src**: remove OCB support ifdef OPENSSL\_NO\_OCB (Shelley Vohr) [#23635](https://github.com/nodejs/node/pull/23635) +* [[`dd91c1d20c`](https://github.com/nodejs/node/commit/dd91c1d20c)] - **src**: change macro to fn (Gino Notto) [#23603](https://github.com/nodejs/node/pull/23603) +* [[`db44a1a5a8`](https://github.com/nodejs/node/commit/db44a1a5a8)] - **src**: add default initializer in tls\_wrap (Richard Hoehn) [#23567](https://github.com/nodejs/node/pull/23567) +* [[`b55fed075c`](https://github.com/nodejs/node/commit/b55fed075c)] - **src**: use MallocedBuffer abstraction for buffers (Cody Hazelwood) [#23543](https://github.com/nodejs/node/pull/23543) +* [[`90cbeae6d9`](https://github.com/nodejs/node/commit/90cbeae6d9)] - **src**: use default initializers over settings fields on the constructor (Andrew J D McCann) [#23532](https://github.com/nodejs/node/pull/23532) +* [[`fa7d0ce486`](https://github.com/nodejs/node/commit/fa7d0ce486)] - **src**: remove unused UVHandle methods (MarianneDr) [#23535](https://github.com/nodejs/node/pull/23535) +* [[`25d7c0213c`](https://github.com/nodejs/node/commit/25d7c0213c)] - **src**: ready background workers before bootstrap (Ali Ijaz Sheikh) [#23233](https://github.com/nodejs/node/pull/23233) +* [[`264d1298b7`](https://github.com/nodejs/node/commit/264d1298b7)] - **src**: move default assignment of async\_id\_ in async\_wrap.h (David Corona) [#23495](https://github.com/nodejs/node/pull/23495) +* [[`8cd41aa742`](https://github.com/nodejs/node/commit/8cd41aa742)] - **src**: fix bug in MallocedBuffer constructor (Tobias Nießen) [#23434](https://github.com/nodejs/node/pull/23434) +* [[`8e198f0494`](https://github.com/nodejs/node/commit/8e198f0494)] - **src**: improve SSL version extraction logic (Gireesh Punathil) [#23050](https://github.com/nodejs/node/pull/23050) +* [[`cdb6da9478`](https://github.com/nodejs/node/commit/cdb6da9478)] - **src**: revert removal of SecureContext `\_external` getter (Vitaly Dyatlov) [#21711](https://github.com/nodejs/node/pull/21711) +* [[`2564abfc99`](https://github.com/nodejs/node/commit/2564abfc99)] - **src**: remove unused limits header from util-inl.h (Daniel Bevenius) [#23353](https://github.com/nodejs/node/pull/23353) +* [[`168885f9c6`](https://github.com/nodejs/node/commit/168885f9c6)] - **src**: replace NO\_RETURN with \[\[noreturn\]\] (Refael Ackermann) [#23337](https://github.com/nodejs/node/pull/23337) +* [[`0b39975cd4`](https://github.com/nodejs/node/commit/0b39975cd4)] - **src**: fix usage of deprecated v8::Date::New (Michaël Zasso) [#23288](https://github.com/nodejs/node/pull/23288) +* [[`c32cf17907`](https://github.com/nodejs/node/commit/c32cf17907)] - **src,win**: informative stack traces (Refael Ackermann) [#23822](https://github.com/nodejs/node/pull/23822) +* [[`1484eeb456`](https://github.com/nodejs/node/commit/1484eeb456)] - **stream**: do not error async iterators on destroy(null) (Matteo Collina) [#23901](https://github.com/nodejs/node/pull/23901) +* [[`5ea25c2a97`](https://github.com/nodejs/node/commit/5ea25c2a97)] - **stream**: ended streams should resolve the async iteration (Matteo Collina) [#23901](https://github.com/nodejs/node/pull/23901) +* [[`dbd37ab256`](https://github.com/nodejs/node/commit/dbd37ab256)] - **stream**: async iteration should work with destroyed stream (Matteo Collina) [#23785](https://github.com/nodejs/node/pull/23785) +* [[`203c420025`](https://github.com/nodejs/node/commit/203c420025)] - **test**: assert that invalidcmd throws error code (Jerome Covington) [#23942](https://github.com/nodejs/node/pull/23942) +* [[`31eff105e0`](https://github.com/nodejs/node/commit/31eff105e0)] - **test**: fix strictEqual arguments order (Esteban Sotillo) [#23956](https://github.com/nodejs/node/pull/23956) +* [[`a15de4876a`](https://github.com/nodejs/node/commit/a15de4876a)] - **test**: add property for RangeError in test-buffer-copy (mritunjaygoutam12) [#23968](https://github.com/nodejs/node/pull/23968) +* [[`b89297b618`](https://github.com/nodejs/node/commit/b89297b618)] - **test**: fix test-fs-watch-system-limit (Ali Ijaz Sheikh) [#23986](https://github.com/nodejs/node/pull/23986) +* [[`ff59c1c97e`](https://github.com/nodejs/node/commit/ff59c1c97e)] - **test**: run code cache test by default and test generator (Joyee Cheung) [#23855](https://github.com/nodejs/node/pull/23855) +* [[`5fb583240e`](https://github.com/nodejs/node/commit/5fb583240e)] - **test**: fix regression when compiled with FIPS (Adam Majer) [#23871](https://github.com/nodejs/node/pull/23871) +* [[`1c6820b9e1`](https://github.com/nodejs/node/commit/1c6820b9e1)] - **test**: fix strictEqual() argument order (Loic) [#23829](https://github.com/nodejs/node/pull/23829) +* [[`f30f11bd5d`](https://github.com/nodejs/node/commit/f30f11bd5d)] - **test**: verify `performance.timerify()` works w/ non-Node Contexts (Anna Henningsen) [#23784](https://github.com/nodejs/node/pull/23784) +* [[`9e9bb85b6c`](https://github.com/nodejs/node/commit/9e9bb85b6c)] - **test**: add test-benchmark-napi (Emily Marigold Klassen) [#23585](https://github.com/nodejs/node/pull/23585) +* [[`60f1a5aae8`](https://github.com/nodejs/node/commit/60f1a5aae8)] - **test**: increase coverage of internal/stream/end-of-stream (Tyler Vann-Campbell) [#23751](https://github.com/nodejs/node/pull/23751) +* [[`01c1ee6730`](https://github.com/nodejs/node/commit/01c1ee6730)] - **test**: fix strictEqual() arguments order (Nolan Rigo) [#23800](https://github.com/nodejs/node/pull/23800) +* [[`79be83dde9`](https://github.com/nodejs/node/commit/79be83dde9)] - **test**: fix invalid modulesLength for DSA keygen (Adam Majer) [#23732](https://github.com/nodejs/node/pull/23732) +* [[`cdf89339e4`](https://github.com/nodejs/node/commit/cdf89339e4)] - **test**: fix test-require-symlink on Windows (Bartosz Sosnowski) [#23691](https://github.com/nodejs/node/pull/23691) +* [[`fd12699f7d`](https://github.com/nodejs/node/commit/fd12699f7d)] - **test**: fix strictEqual() argument order (Romain Lanz) [#23768](https://github.com/nodejs/node/pull/23768) +* [[`6ee9273e9e`](https://github.com/nodejs/node/commit/6ee9273e9e)] - **test**: fix strictEqual() arguments order (Thomas GENTILHOMME) [#23771](https://github.com/nodejs/node/pull/23771) +* [[`4116788f76`](https://github.com/nodejs/node/commit/4116788f76)] - **test**: fix assertion arguments order (Elian Gutierrez) [#23787](https://github.com/nodejs/node/pull/23787) +* [[`4673848025`](https://github.com/nodejs/node/commit/4673848025)] - **test**: add blocks and comments to fs-promises tests (Ian Sutherland) [#23627](https://github.com/nodejs/node/pull/23627) +* [[`9ad176ab50`](https://github.com/nodejs/node/commit/9ad176ab50)] - **test**: add a test for `tls.Socket` with `allowHalfOpen` (Ouyang Yadong) [#23866](https://github.com/nodejs/node/pull/23866) +* [[`874371df89`](https://github.com/nodejs/node/commit/874371df89)] - **test**: increase coverage for readfile with withFileTypes (christian-bromann) [#23557](https://github.com/nodejs/node/pull/23557) +* [[`ce03acac71`](https://github.com/nodejs/node/commit/ce03acac71)] - **test**: skip failing tests for osx mojave (jn99) [#23550](https://github.com/nodejs/node/pull/23550) +* [[`8552bb4065`](https://github.com/nodejs/node/commit/8552bb4065)] - **test**: enable trace-events tests for workers (Richard Lau) [#23698](https://github.com/nodejs/node/pull/23698) +* [[`8e7a12f450`](https://github.com/nodejs/node/commit/8e7a12f450)] - **test**: improve test coverage for fs module (garrik.leonardo@gmail.com) [#23601](https://github.com/nodejs/node/pull/23601) +* [[`0b7aa275a9`](https://github.com/nodejs/node/commit/0b7aa275a9)] - **test**: fix argument order in assertion (Illescas, Ricardo) [#23581](https://github.com/nodejs/node/pull/23581) +* [[`4e019f05bc`](https://github.com/nodejs/node/commit/4e019f05bc)] - **test**: reversed params in assert.strictEqual() (Dusan Radovanovic) [#23591](https://github.com/nodejs/node/pull/23591) +* [[`ff9232db35`](https://github.com/nodejs/node/commit/ff9232db35)] - **test**: correct order of args in buffer compare (James Irwin) [#23521](https://github.com/nodejs/node/pull/23521) +* [[`11eabba0fb`](https://github.com/nodejs/node/commit/11eabba0fb)] - **test**: check codes of thrown errors (Nancy Truong) [#23519](https://github.com/nodejs/node/pull/23519) +* [[`79d7733c59`](https://github.com/nodejs/node/commit/79d7733c59)] - **test**: fix strictEqual arguments order (Jonathan Samines) [#23486](https://github.com/nodejs/node/pull/23486) +* [[`642b1686be`](https://github.com/nodejs/node/commit/642b1686be)] - **test**: add test coverage for fs.truncate (christian-bromann) [#23620](https://github.com/nodejs/node/pull/23620) +* [[`f82611a27e`](https://github.com/nodejs/node/commit/f82611a27e)] - **test**: use smaller keys for a faster keygen test (Sam Roberts) [#23430](https://github.com/nodejs/node/pull/23430) +* [[`e8ca33025a`](https://github.com/nodejs/node/commit/e8ca33025a)] - **test**: increased code coverage for slowCases (Jared Haines) [#23592](https://github.com/nodejs/node/pull/23592) +* [[`002c35cd42`](https://github.com/nodejs/node/commit/002c35cd42)] - **test**: assertions arguments match docs (Amanuel Ghebreweldi) [#23594](https://github.com/nodejs/node/pull/23594) +* [[`3d703042c1`](https://github.com/nodejs/node/commit/3d703042c1)] - **test**: fix assert.strictEqual() argument order (Derek) [#23598](https://github.com/nodejs/node/pull/23598) +* [[`25b166a5cb`](https://github.com/nodejs/node/commit/25b166a5cb)] - **test**: fix assert parameter order in test-https-localaddress.js (Ian Sutherland) [#23599](https://github.com/nodejs/node/pull/23599) +* [[`e98d8f427c`](https://github.com/nodejs/node/commit/e98d8f427c)] - **test**: change order of assert.strictEquals arguments (Chuck Theobald) [#23600](https://github.com/nodejs/node/pull/23600) +* [[`8d39cf6323`](https://github.com/nodejs/node/commit/8d39cf6323)] - **test**: fix assert equal order of arguments (David Jiang) [#23602](https://github.com/nodejs/node/pull/23602) +* [[`af6528ab85`](https://github.com/nodejs/node/commit/af6528ab85)] - **test**: fix order of assert args in client response domain test (Emily Kolar) [#23604](https://github.com/nodejs/node/pull/23604) +* [[`984fac4a53`](https://github.com/nodejs/node/commit/984fac4a53)] - **test**: re-order strictEqual paramater calls (Paul Tichonczuk) [#23607](https://github.com/nodejs/node/pull/23607) +* [[`37e1101a0f`](https://github.com/nodejs/node/commit/37e1101a0f)] - **test**: fix assertions args order (Milton Sosa) [#23608](https://github.com/nodejs/node/pull/23608) +* [[`0c9a866541`](https://github.com/nodejs/node/commit/0c9a866541)] - **test**: fix parameters in test-repl.js (Israel Ortiz) [#23609](https://github.com/nodejs/node/pull/23609) +* [[`d370c5e8c1`](https://github.com/nodejs/node/commit/d370c5e8c1)] - **test**: reverse arguments in assert.strictEqual (Vsevolod Geraskin) [#23613](https://github.com/nodejs/node/pull/23613) +* [[`4d9059b1df`](https://github.com/nodejs/node/commit/4d9059b1df)] - **test**: update assertion parameter order (Sean Healy) [#23614](https://github.com/nodejs/node/pull/23614) +* [[`6d80af3112`](https://github.com/nodejs/node/commit/6d80af3112)] - **test**: fix backward assertion arguments (Stéphane Vasseur) [#23616](https://github.com/nodejs/node/pull/23616) +* [[`202d38c484`](https://github.com/nodejs/node/commit/202d38c484)] - **test**: reversed 1st and 2nd arguments for assert.strictEqual() (vchoubey08) [#23617](https://github.com/nodejs/node/pull/23617) +* [[`9fb6cf01f9`](https://github.com/nodejs/node/commit/9fb6cf01f9)] - **test**: correct assertion argument order (Jeff Marvin) [#23618](https://github.com/nodejs/node/pull/23618) +* [[`64268d005a`](https://github.com/nodejs/node/commit/64268d005a)] - **test**: fix assertion order (erickwendel) [#23626](https://github.com/nodejs/node/pull/23626) +* [[`4874ce2106`](https://github.com/nodejs/node/commit/4874ce2106)] - **test**: updated assert test values to doc standards (keeysnc) [#23593](https://github.com/nodejs/node/pull/23593) +* [[`57b4fc16c3`](https://github.com/nodejs/node/commit/57b4fc16c3)] - **test**: switch order of assertion arguments (Mel) [#23563](https://github.com/nodejs/node/pull/23563) +* [[`e0b4dab586`](https://github.com/nodejs/node/commit/e0b4dab586)] - **test**: fix assert.strictEqual() argument order (Savio Resende) [#23564](https://github.com/nodejs/node/pull/23564) +* [[`0fcbe2c8ba`](https://github.com/nodejs/node/commit/0fcbe2c8ba)] - **test**: fix parameter order of assertions (Pete Lombardo) [#23565](https://github.com/nodejs/node/pull/23565) +* [[`7c7f8068be`](https://github.com/nodejs/node/commit/7c7f8068be)] - **test**: fix assert value order (Ethan Weber) [#23566](https://github.com/nodejs/node/pull/23566) +* [[`ef2777db40`](https://github.com/nodejs/node/commit/ef2777db40)] - **test**: fix strictEqual order for timers test (Saleh Abdel Motaal) [#23568](https://github.com/nodejs/node/pull/23568) +* [[`2cb4789a68`](https://github.com/nodejs/node/commit/2cb4789a68)] - **test**: corrected assertion arguments order (francois) [#23569](https://github.com/nodejs/node/pull/23569) +* [[`110606daa5`](https://github.com/nodejs/node/commit/110606daa5)] - **test**: fix strictEqual input parameters order (AlixAng) [#23570](https://github.com/nodejs/node/pull/23570) +* [[`bcf24e7a4d`](https://github.com/nodejs/node/commit/bcf24e7a4d)] - **test**: fix order of arguments passed to strictEqual (Joe Shindelar) [#23571](https://github.com/nodejs/node/pull/23571) +* [[`2a3ba01b08`](https://github.com/nodejs/node/commit/2a3ba01b08)] - **test**: fix arguments ordering for assertions to match the docs (Liran Tal) [#23575](https://github.com/nodejs/node/pull/23575) +* [[`b68ee2238f`](https://github.com/nodejs/node/commit/b68ee2238f)] - **test**: fixed strictEqual arguments order (Ruy Adorno) [#23576](https://github.com/nodejs/node/pull/23576) +* [[`2ea96196fe`](https://github.com/nodejs/node/commit/2ea96196fe)] - **test**: add crypto.scrypt test case with different encoding (Yitong) [#23578](https://github.com/nodejs/node/pull/23578) +* [[`6ec5b4a84d`](https://github.com/nodejs/node/commit/6ec5b4a84d)] - **test**: reversed actual and expected values for .strictEqual() (Salman Shakeel) [#23579](https://github.com/nodejs/node/pull/23579) +* [[`70ba0f97a0`](https://github.com/nodejs/node/commit/70ba0f97a0)] - **test**: increased code coverage for proxySessionHandler (Justin Lee) [#23583](https://github.com/nodejs/node/pull/23583) +* [[`18ea8cfbdd`](https://github.com/nodejs/node/commit/18ea8cfbdd)] - **test**: fix assertion arguments order (seantcoyote) [#23584](https://github.com/nodejs/node/pull/23584) +* [[`c9ba20aeca`](https://github.com/nodejs/node/commit/c9ba20aeca)] - **test**: fix assert.strictEqual() parameter order in test-path-maklong.js (blakehall) [#23587](https://github.com/nodejs/node/pull/23587) +* [[`8b38c2e1c0`](https://github.com/nodejs/node/commit/8b38c2e1c0)] - **test**: fix argument order in assertions (Illescas, Ricardo) [#23589](https://github.com/nodejs/node/pull/23589) +* [[`9439e3e973`](https://github.com/nodejs/node/commit/9439e3e973)] - **test**: fix order of parameters to assert.strictEqual (Jason Nutter) [#23590](https://github.com/nodejs/node/pull/23590) +* [[`760b5715d9`](https://github.com/nodejs/node/commit/760b5715d9)] - **test**: removed unused variable in fs-watch-file-slow (Maki Toda) [#23548](https://github.com/nodejs/node/pull/23548) +* [[`04769c4573`](https://github.com/nodejs/node/commit/04769c4573)] - **test**: update strictEqual arguments order (Clinton Pahl) [#23552](https://github.com/nodejs/node/pull/23552) +* [[`042e97428f`](https://github.com/nodejs/node/commit/042e97428f)] - **test**: removed unused error variable in try catch (Murtaza H) [#23553](https://github.com/nodejs/node/pull/23553) +* [[`fc2f104efe`](https://github.com/nodejs/node/commit/fc2f104efe)] - **test**: reverse order of args in reconnect-error assert (Jackelin Herrera) [#23555](https://github.com/nodejs/node/pull/23555) +* [[`abf19da10f`](https://github.com/nodejs/node/commit/abf19da10f)] - **test**: added async-hook benchmark (peter) [#23556](https://github.com/nodejs/node/pull/23556) +* [[`0569bfeab1`](https://github.com/nodejs/node/commit/0569bfeab1)] - **test**: fix order of assert arguments in vm-new-script-this-context (Victor Poriazov) [#23558](https://github.com/nodejs/node/pull/23558) +* [[`fc05ca56e7`](https://github.com/nodejs/node/commit/fc05ca56e7)] - **test**: modernize test-crypto-domain (naris93) [#23559](https://github.com/nodejs/node/pull/23559) +* [[`77f2100469`](https://github.com/nodejs/node/commit/77f2100469)] - **test**: fix strictEqual assertion order on readline tests (Joe Grosspietsch) [#23561](https://github.com/nodejs/node/pull/23561) +* [[`8d583a7b40`](https://github.com/nodejs/node/commit/8d583a7b40)] - **test**: switch strictEqual parameters - actual first before expected (Chris Bautista) [#23537](https://github.com/nodejs/node/pull/23537) +* [[`a410488994`](https://github.com/nodejs/node/commit/a410488994)] - **test**: assert.strictEqual parameters ordered correctly (Justin denBroeder) [#23538](https://github.com/nodejs/node/pull/23538) +* [[`5bf919e818`](https://github.com/nodejs/node/commit/5bf919e818)] - **test**: fix assert.strictEqual() arguments order (Ivan Lukasevych) [#23539](https://github.com/nodejs/node/pull/23539) +* [[`21a46ef123`](https://github.com/nodejs/node/commit/21a46ef123)] - **test**: reverse the order of assertion statement arguments in pingpong test (Allan Zheng) [#23540](https://github.com/nodejs/node/pull/23540) +* [[`e5500f823d`](https://github.com/nodejs/node/commit/e5500f823d)] - **test**: added test for generateKeyPair (David Xue) [#23541](https://github.com/nodejs/node/pull/23541) +* [[`adc89e30cf`](https://github.com/nodejs/node/commit/adc89e30cf)] - **test**: swap expected and actual arguments in assert.strictEqual() (Erin Bush) [#23542](https://github.com/nodejs/node/pull/23542) +* [[`6e5a5ff654`](https://github.com/nodejs/node/commit/6e5a5ff654)] - **test**: fix assertions argument order (KelvinLawHF1) [#23544](https://github.com/nodejs/node/pull/23544) +* [[`02b0688003`](https://github.com/nodejs/node/commit/02b0688003)] - **test**: fix assertion argument order (Carl Richmond) [#23545](https://github.com/nodejs/node/pull/23545) +* [[`4c27cf0a41`](https://github.com/nodejs/node/commit/4c27cf0a41)] - **test**: refactor callback functions to arrow functions (Sean Healy) [#23546](https://github.com/nodejs/node/pull/23546) +* [[`1e8ce06732`](https://github.com/nodejs/node/commit/1e8ce06732)] - **test**: updating assertion and expect order in test-tls-client-verify.js (Eli Itah) [#23547](https://github.com/nodejs/node/pull/23547) +* [[`efdbc2d846`](https://github.com/nodejs/node/commit/efdbc2d846)] - **test**: use correct argument order for assert.strictEqual() (Oktavianus Ludiro) [#23527](https://github.com/nodejs/node/pull/23527) +* [[`5d7c15bc6d`](https://github.com/nodejs/node/commit/5d7c15bc6d)] - **test**: corrected the order of arguments in assert.strictEqual() (Diana Lee) [#23528](https://github.com/nodejs/node/pull/23528) +* [[`8e69895603`](https://github.com/nodejs/node/commit/8e69895603)] - **test**: fix assert.strictEqual() argument order (ssamuels0916) [#23529](https://github.com/nodejs/node/pull/23529) +* [[`93af93ae9f`](https://github.com/nodejs/node/commit/93af93ae9f)] - **test**: fix strictEqual assertion argument in test-tls-ecdh-auto (jaxyz) [#23530](https://github.com/nodejs/node/pull/23530) +* [[`0895576d10`](https://github.com/nodejs/node/commit/0895576d10)] - **test**: correct labelling of asserts errors (nofwayy) [#23531](https://github.com/nodejs/node/pull/23531) +* [[`474b401794`](https://github.com/nodejs/node/commit/474b401794)] - **test**: reorder asserts arguments (Marcos Frony) [#23534](https://github.com/nodejs/node/pull/23534) +* [[`de8ffbad80`](https://github.com/nodejs/node/commit/de8ffbad80)] - **test**: updating assertion on test so it fits the new method signature (garrik.leonardo@gmail.com) [#23536](https://github.com/nodejs/node/pull/23536) +* [[`7cd9161ea4`](https://github.com/nodejs/node/commit/7cd9161ea4)] - **test**: refactor functions to es6 (Michael Chen) [#23510](https://github.com/nodejs/node/pull/23510) +* [[`22a4ec1d70`](https://github.com/nodejs/node/commit/22a4ec1d70)] - **test**: replaced functions with arrow functions (edgarzapeka) [#23511](https://github.com/nodejs/node/pull/23511) +* [[`a0985281ee`](https://github.com/nodejs/node/commit/a0985281ee)] - **test**: corret assertion arg order in test-regress-GH-892.js (Elvis-Philip N) [#23513](https://github.com/nodejs/node/pull/23513) +* [[`608d5fa8f0`](https://github.com/nodejs/node/commit/608d5fa8f0)] - **test**: fix test-dgram-pingpong assertion arg order (David Ward) [#23514](https://github.com/nodejs/node/pull/23514) +* [[`0d6d6f63cd`](https://github.com/nodejs/node/commit/0d6d6f63cd)] - **test**: fix assert.strictEqual() argument order (Ben Schaaf) [#23515](https://github.com/nodejs/node/pull/23515) +* [[`161cbbb97a`](https://github.com/nodejs/node/commit/161cbbb97a)] - **test**: fix assert.strictEqual arg order in test-tls-ecdh-multiple.js (Takdeer Sodhan) [#23516](https://github.com/nodejs/node/pull/23516) +* [[`ad83caf7fa`](https://github.com/nodejs/node/commit/ad83caf7fa)] - **test**: use the correct parameter order on assert.strictEqual() (Tyler Vann-Campbell) [#23520](https://github.com/nodejs/node/pull/23520) +* [[`b7d4404e87`](https://github.com/nodejs/node/commit/b7d4404e87)] - **test**: fix assert order in test-vm-context (Lee Gray) [#23523](https://github.com/nodejs/node/pull/23523) +* [[`9dc11e3354`](https://github.com/nodejs/node/commit/9dc11e3354)] - **test**: switch arguments of assert() (Arne Schramm) [#23524](https://github.com/nodejs/node/pull/23524) +* [[`4f116a7009`](https://github.com/nodejs/node/commit/4f116a7009)] - **test**: swap assert argument order in test-vm-create-and-run-in-context.js (Pascal Lambert) [#23525](https://github.com/nodejs/node/pull/23525) +* [[`ff5345cf5c`](https://github.com/nodejs/node/commit/ff5345cf5c)] - **test**: fix order of assert.strictEqual() args to actual, expected (Joshua Belcher) [#23501](https://github.com/nodejs/node/pull/23501) +* [[`f5fd8a2168`](https://github.com/nodejs/node/commit/f5fd8a2168)] - **test**: fixed incorrect variable order in assert.strictEqual() (Daniyal Mokhammad) [#23502](https://github.com/nodejs/node/pull/23502) +* [[`66c82adb0e`](https://github.com/nodejs/node/commit/66c82adb0e)] - **test**: properly order test assertion variables (David Scott) [#23503](https://github.com/nodejs/node/pull/23503) +* [[`28b6129a7b`](https://github.com/nodejs/node/commit/28b6129a7b)] - **test**: modernize test-child-process-flush-stdio (Viacheslav Liakhov) [#23504](https://github.com/nodejs/node/pull/23504) +* [[`23d6932c61`](https://github.com/nodejs/node/commit/23d6932c61)] - **test**: put expected assert value in correct place (Jean-Francois Arseneau) [#23505](https://github.com/nodejs/node/pull/23505) +* [[`d590aa858d`](https://github.com/nodejs/node/commit/d590aa858d)] - **test**: fix argument order in assertions (Illescas, Ricardo) [#23506](https://github.com/nodejs/node/pull/23506) +* [[`119fc3abdd`](https://github.com/nodejs/node/commit/119fc3abdd)] - **test**: fix assertions args order in test/parallel/test-fs-chmod.js (Milton Sosa) [#23507](https://github.com/nodejs/node/pull/23507) +* [[`6f590be539`](https://github.com/nodejs/node/commit/6f590be539)] - **test**: fix strictEqual assertion arguments (Alejandro Oviedo Garcia) [#23508](https://github.com/nodejs/node/pull/23508) +* [[`d156d093ff`](https://github.com/nodejs/node/commit/d156d093ff)] - **test**: fix ordering of assertion values (Andrew MacCuaig) +* [[`fd5290e68c`](https://github.com/nodejs/node/commit/fd5290e68c)] - **test**: update function keywords to fat arrows (Robert Monks) [#23493](https://github.com/nodejs/node/pull/23493) +* [[`e9f17464a8`](https://github.com/nodejs/node/commit/e9f17464a8)] - **test**: reversed arguments in strictqual to reflect documentation (scabhi) [#23494](https://github.com/nodejs/node/pull/23494) +* [[`f1fb2bea5e`](https://github.com/nodejs/node/commit/f1fb2bea5e)] - **test**: modernized test to use arrow functions (Greg Goforth) [#23496](https://github.com/nodejs/node/pull/23496) +* [[`627e3ad241`](https://github.com/nodejs/node/commit/627e3ad241)] - **test**: use arrow functions in test-exception-handler (Jenna Zeigen) [#23498](https://github.com/nodejs/node/pull/23498) +* [[`13afb68e8a`](https://github.com/nodejs/node/commit/13afb68e8a)] - **test**: fix argument order in asserts (@CAYdenberg) [#23499](https://github.com/nodejs/node/pull/23499) +* [[`e0a3e238bb`](https://github.com/nodejs/node/commit/e0a3e238bb)] - **test**: modernizing test-dgram-listen-after-bind with arrow functions (chrisforrette) [#23500](https://github.com/nodejs/node/pull/23500) +* [[`01d599cffe`](https://github.com/nodejs/node/commit/01d599cffe)] - **test**: fix strictEqual argument order (Felix Schlenkrich) [#23490](https://github.com/nodejs/node/pull/23490) +* [[`58aaa61363`](https://github.com/nodejs/node/commit/58aaa61363)] - **test**: rename process.argv\[0\] to process.execPath, rename ex to err (Kayla Altepeter) [#23488](https://github.com/nodejs/node/pull/23488) +* [[`7e56801ddd`](https://github.com/nodejs/node/commit/7e56801ddd)] - **test**: fix assertion argument order (Carl Richmond) [#23489](https://github.com/nodejs/node/pull/23489) +* [[`16175c1b89`](https://github.com/nodejs/node/commit/16175c1b89)] - **test**: fix assertion order test-tls-server-verify (Carolina Pinzon) [#23549](https://github.com/nodejs/node/pull/23549) +* [[`ac0a03a278`](https://github.com/nodejs/node/commit/ac0a03a278)] - **test**: fix assertion order (Chris Nguyen) [#23533](https://github.com/nodejs/node/pull/23533) +* [[`bf20cf8ba2`](https://github.com/nodejs/node/commit/bf20cf8ba2)] - **test**: change to arrow functions in send-bad-arguments (Anna Zhao) [#23483](https://github.com/nodejs/node/pull/23483) +* [[`b29b836d04`](https://github.com/nodejs/node/commit/b29b836d04)] - **test**: removed unused variable (Michal Hynek) [#23481](https://github.com/nodejs/node/pull/23481) +* [[`b083715671`](https://github.com/nodejs/node/commit/b083715671)] - **test**: fix argument order for assert.strictEqual (Stacey) [#23485](https://github.com/nodejs/node/pull/23485) +* [[`d6dabc79c5`](https://github.com/nodejs/node/commit/d6dabc79c5)] - **test**: fix assert.strictEqual params order (Rock Hu) [#23480](https://github.com/nodejs/node/pull/23480) +* [[`87367eccbb`](https://github.com/nodejs/node/commit/87367eccbb)] - **test**: removed mustCallAsync from common and added inside testcase (Quinn Langille) [#23467](https://github.com/nodejs/node/pull/23467) +* [[`46f944f700`](https://github.com/nodejs/node/commit/46f944f700)] - **test**: remove unused "e" from catch in http2 test (Stephen Heitman) [#23476](https://github.com/nodejs/node/pull/23476) +* [[`adff51fc11`](https://github.com/nodejs/node/commit/adff51fc11)] - **test**: remove unused variable from catch (Paige Kato) [#23477](https://github.com/nodejs/node/pull/23477) +* [[`d7609a7a07`](https://github.com/nodejs/node/commit/d7609a7a07)] - **test**: inline common module boolean (ashleysimpson) [#23479](https://github.com/nodejs/node/pull/23479) +* [[`c73a6a05d1`](https://github.com/nodejs/node/commit/c73a6a05d1)] - **test**: swap the order arguments are passed to assert (Dylson Valente Neto) [#23580](https://github.com/nodejs/node/pull/23580) +* [[`da17d97d82`](https://github.com/nodejs/node/commit/da17d97d82)] - **test**: flip assertion arguments for make-callback/test.js (Tim Cheung) [#23470](https://github.com/nodejs/node/pull/23470) +* [[`b436ccc3b2`](https://github.com/nodejs/node/commit/b436ccc3b2)] - **test**: replace function with arrow function (Yitong) [#23474](https://github.com/nodejs/node/pull/23474) +* [[`a6787a7f2b`](https://github.com/nodejs/node/commit/a6787a7f2b)] - **test**: swap actual and expected in assertions (Yitong) [#23474](https://github.com/nodejs/node/pull/23474) +* [[`148d4e4b8e`](https://github.com/nodejs/node/commit/148d4e4b8e)] - **test**: correctly order assertion arguments (Emily Kolar) [#23473](https://github.com/nodejs/node/pull/23473) +* [[`75d4bf2348`](https://github.com/nodejs/node/commit/75d4bf2348)] - **test**: mark `test-http2-session-timeout` as flake on ARM (Refael Ackermann) [#23639](https://github.com/nodejs/node/pull/23639) +* [[`65ea85f4a3`](https://github.com/nodejs/node/commit/65ea85f4a3)] - **test**: update test-cluster-worker-events to use arrow functions (S. Everett Abbott) [#23469](https://github.com/nodejs/node/pull/23469) +* [[`1a39a56f6c`](https://github.com/nodejs/node/commit/1a39a56f6c)] - **test**: correct order for assert.strictEqual for inspector-helper test (Maggie Nolan) [#23468](https://github.com/nodejs/node/pull/23468) +* [[`f8e7112b91`](https://github.com/nodejs/node/commit/f8e7112b91)] - **test**: fix incorrect expectation order (Amie) [#23466](https://github.com/nodejs/node/pull/23466) +* [[`77ef4970f6`](https://github.com/nodejs/node/commit/77ef4970f6)] - **test**: remove unused e variable in catch statement (Denny Scott) [#23465](https://github.com/nodejs/node/pull/23465) +* [[`ed9f8acc79`](https://github.com/nodejs/node/commit/ed9f8acc79)] - **test**: correct assert test (Richard Markins) [#23463](https://github.com/nodejs/node/pull/23463) +* [[`eac6ba94f1`](https://github.com/nodejs/node/commit/eac6ba94f1)] - **test**: fix incorrect ordering of args in assert.strictEqual() (mdaum) [#23461](https://github.com/nodejs/node/pull/23461) +* [[`8766d27598`](https://github.com/nodejs/node/commit/8766d27598)] - **test**: swap assert.strictEqual args to actual, expected (epeden) [#23459](https://github.com/nodejs/node/pull/23459) +* [[`2f920ce497`](https://github.com/nodejs/node/commit/2f920ce497)] - **test**: fix assert.strictEqual argument order (andy addington) [#23457](https://github.com/nodejs/node/pull/23457) +* [[`58a5b76a58`](https://github.com/nodejs/node/commit/58a5b76a58)] - **test**: strictEqual correct order for http-information-processing test (Ivan Sieder) [#23456](https://github.com/nodejs/node/pull/23456) +* [[`e5a2fa2dcb`](https://github.com/nodejs/node/commit/e5a2fa2dcb)] - **test**: fix http local address test assertion (Danu Widatama) [#23451](https://github.com/nodejs/node/pull/23451) +* [[`8a9b2b6168`](https://github.com/nodejs/node/commit/8a9b2b6168)] - **test**: fix order of values in test assertions (Jared Haines) [#23450](https://github.com/nodejs/node/pull/23450) +* [[`31a96600fb`](https://github.com/nodejs/node/commit/31a96600fb)] - **test**: fix `assert.strictEqual` arguments in test/parallel/test-c-ares.js (jungkumseok) [#23448](https://github.com/nodejs/node/pull/23448) +* [[`b3e43a6393`](https://github.com/nodejs/node/commit/b3e43a6393)] - **test**: fix parameter order passed to strictEqual (Shannon) [#23577](https://github.com/nodejs/node/pull/23577) +* [[`484dccbd44`](https://github.com/nodejs/node/commit/484dccbd44)] - **test**: adding test coverage for SourceTextModule.evaluate (Kayla Altepeter) [#23595](https://github.com/nodejs/node/pull/23595) +* [[`2d3292225f`](https://github.com/nodejs/node/commit/2d3292225f)] - **test**: rename common.ddCommand() (Rich Trott) [#23411](https://github.com/nodejs/node/pull/23411) +* [[`2f84a189c7`](https://github.com/nodejs/node/commit/2f84a189c7)] - **test**: refactor common.ddCommand() (Rich Trott) [#23411](https://github.com/nodejs/node/pull/23411) +* [[`65ae332098`](https://github.com/nodejs/node/commit/65ae332098)] - **test**: move some gc tests back to parallel/, unmark flaky (Anna Henningsen) [#23356](https://github.com/nodejs/node/pull/23356) +* [[`21c3822719`](https://github.com/nodejs/node/commit/21c3822719)] - **test**: improve test-gc-http-client-onerror (Denys Otrishko) [#23196](https://github.com/nodejs/node/pull/23196) +* [[`693a50e494`](https://github.com/nodejs/node/commit/693a50e494)] - **test**: improve test-gc-http-client-connaborted (Denys Otrishko) [#23193](https://github.com/nodejs/node/pull/23193) +* [[`6fa033c5b1`](https://github.com/nodejs/node/commit/6fa033c5b1)] - **test**: fix assert.strictEqual argument order (et4891) [#23518](https://github.com/nodejs/node/pull/23518) +* [[`305c1e15fd`](https://github.com/nodejs/node/commit/305c1e15fd)] - **test**: fixing assertion value order (Joe Sepi) [#23574](https://github.com/nodejs/node/pull/23574) +* [[`3024e3abed`](https://github.com/nodejs/node/commit/3024e3abed)] - **test**: separate WPT console test from other test (Rich Trott) [#23340](https://github.com/nodejs/node/pull/23340) +* [[`75a849aadf`](https://github.com/nodejs/node/commit/75a849aadf)] - **test**: add WPT console-label-conversion test (Rich Trott) [#23340](https://github.com/nodejs/node/pull/23340) +* [[`a1fef95500`](https://github.com/nodejs/node/commit/a1fef95500)] - **test**: rename WPT console test (Rich Trott) [#23340](https://github.com/nodejs/node/pull/23340) +* [[`27dd4dee0d`](https://github.com/nodejs/node/commit/27dd4dee0d)] - **test**: add logging to test-worker-memory (Rich Trott) [#23418](https://github.com/nodejs/node/pull/23418) +* [[`e865418138`](https://github.com/nodejs/node/commit/e865418138)] - **test**: add test for a vm indexed property (conectado) [#23318](https://github.com/nodejs/node/pull/23318) +* [[`dad3d7468b`](https://github.com/nodejs/node/commit/dad3d7468b)] - **test**: fix compiler warning in doc/api/addons.md (Daniel Bevenius) [#23323](https://github.com/nodejs/node/pull/23323) +* [[`9aec3e6863`](https://github.com/nodejs/node/commit/9aec3e6863)] - **tls**: close StreamWrap and its stream correctly (Ouyang Yadong) [#23654](https://github.com/nodejs/node/pull/23654) +* [[`81dc2419f4`](https://github.com/nodejs/node/commit/81dc2419f4)] - **tls**: prevent multiple connection errors (cjihrig) [#23636](https://github.com/nodejs/node/pull/23636) +* [[`1afd2071ee`](https://github.com/nodejs/node/commit/1afd2071ee)] - **tls**: make StreamWrap work correctly in "drain" callback (Ouyang Yadong) [#23294](https://github.com/nodejs/node/pull/23294) +* [[`e973b5df74`](https://github.com/nodejs/node/commit/e973b5df74)] - **tools**: update alternative docs versions (Richard Lau) [#23980](https://github.com/nodejs/node/pull/23980) +* [[`3249a57f2b`](https://github.com/nodejs/node/commit/3249a57f2b)] - **tools**: update ESLint to 5.8.0 (cjihrig) [#23904](https://github.com/nodejs/node/pull/23904) +* [[`703f40a035`](https://github.com/nodejs/node/commit/703f40a035)] - **tools**: clarify commit message linting (Rich Trott) [#23742](https://github.com/nodejs/node/pull/23742) +* [[`28599e896a`](https://github.com/nodejs/node/commit/28599e896a)] - **tools**: do not lint commit message if var undefined (Rich Trott) [#23725](https://github.com/nodejs/node/pull/23725) +* [[`ac83a14714`](https://github.com/nodejs/node/commit/ac83a14714)] - **tools**: prefer filter to remove empty strings (Sakthipriyan Vairamani (thefourtheye)) [#23727](https://github.com/nodejs/node/pull/23727) +* [[`6af2f9f946`](https://github.com/nodejs/node/commit/6af2f9f946)] - **tools**: update ESLint to 5.7.0 (cjihrig) [#23629](https://github.com/nodejs/node/pull/23629) +* [[`47eb9484ab`](https://github.com/nodejs/node/commit/47eb9484ab)] - **tools**: update node-lint-md-cli-rollup (Rich Trott) [#23358](https://github.com/nodejs/node/pull/23358) +* [[`43446671e1`](https://github.com/nodejs/node/commit/43446671e1)] - **tools,icu**: read full ICU version info from file (Refael Ackermann) [#23269](https://github.com/nodejs/node/pull/23269) +* [[`9e03393ff2`](https://github.com/nodejs/node/commit/9e03393ff2)] - **tools,test**: add list of slow tests (Refael Ackermann) [#23251](https://github.com/nodejs/node/pull/23251) +* [[`148ae30fd7`](https://github.com/nodejs/node/commit/148ae30fd7)] - **tools,test**: cleanup and dedup code (Refael Ackermann) [#23251](https://github.com/nodejs/node/pull/23251) +* [[`808f37c97f`](https://github.com/nodejs/node/commit/808f37c97f)] - **trace_events**: destroy platform before tracing (Ali Ijaz Sheikh) [#22938](https://github.com/nodejs/node/pull/22938) +* [[`3df083c5fb`](https://github.com/nodejs/node/commit/3df083c5fb)] - **util**: handle null prototype on inspect (Anto Aravinth) [#22331](https://github.com/nodejs/node/pull/22331) +* [[`ffadcc1b22`](https://github.com/nodejs/node/commit/ffadcc1b22)] - **vm**: pass parsing\_context to ScriptCompiler::CompileFunctionInContext (Dara Hayes) [#23206](https://github.com/nodejs/node/pull/23206) +* [[`257a5e9c38`](https://github.com/nodejs/node/commit/257a5e9c38)] - **win**: add prompt to tools installation script (João Reis) [#23987](https://github.com/nodejs/node/pull/23987) +* [[`e9a291582d`](https://github.com/nodejs/node/commit/e9a291582d)] - **win**: clarify Boxstarter behavior on install tools (Rob Reynolds) [#23987](https://github.com/nodejs/node/pull/23987) +* [[`469473d550`](https://github.com/nodejs/node/commit/469473d550)] - ***Revert*** "**win,msi**: install tools for native modules" (Refael Ackermann) [#24344](https://github.com/nodejs/node/pull/24344) +* [[`1c17aa1e43`](https://github.com/nodejs/node/commit/1c17aa1e43)] - **worker**: remove delete MessagePort.prototype.hasRef (James Traver) [#23471](https://github.com/nodejs/node/pull/23471) +* [[`179d4c7269`](https://github.com/nodejs/node/commit/179d4c7269)] - **zlib**: refactor zlib internals (Anna Henningsen) [#23360](https://github.com/nodejs/node/pull/23360) +* [[`7fd1b4dd4b`](https://github.com/nodejs/node/commit/7fd1b4dd4b)] - **zlib**: generate error code names in C++ (Anna Henningsen) [#23413](https://github.com/nodejs/node/pull/23413) + ## 2018-10-30, Version 10.13.0 'Dubnium' (LTS), @MylesBorins diff --git a/src/node_version.h b/src/node_version.h index b8cf9aa6d0408a..fbf5dd0b35eda8 100644 --- a/src/node_version.h +++ b/src/node_version.h @@ -24,12 +24,12 @@ #define NODE_MAJOR_VERSION 10 #define NODE_MINOR_VERSION 13 -#define NODE_PATCH_VERSION 1 +#define NODE_PATCH_VERSION 2 #define NODE_VERSION_IS_LTS 1 #define NODE_VERSION_LTS_CODENAME "Dubnium" -#define NODE_VERSION_IS_RELEASE 0 +#define NODE_VERSION_IS_RELEASE 1 #ifndef NODE_STRINGIFY #define NODE_STRINGIFY(n) NODE_STRINGIFY_HELPER(n)