Skip to content

Commit

Permalink
src: remove ignore GCC -Wcast-function-type for v8
Browse files Browse the repository at this point in the history
This reverts Commit 3ff2aec ("src:
ignore GCC -Wcast-function-type for v8.h") and Commit
2462a2c ("src: fix ignore GCC
-Wcast-function-type for older compilers") as this has
now been included in the V8 version being used.

PR-URL: #35768
Refs: v8/v8@f08cbfd
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
  • Loading branch information
danbev authored and targos committed Nov 3, 2020
1 parent 4b8b5fe commit 4128eef
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 21 deletions.
7 changes: 0 additions & 7 deletions src/base_object-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,7 @@
#include "env-inl.h"
#include "util.h"

#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wcast-function-type"
#endif
#include "v8.h"
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic pop
#endif

namespace node {

Expand Down
7 changes: 0 additions & 7 deletions src/node.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,7 @@
# define SIGKILL 9
#endif

#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wcast-function-type"
#endif
#include "v8.h" // NOLINT(build/include_order)
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic pop
#endif

#include "v8-platform.h" // NOLINT(build/include_order)
#include "node_version.h" // NODE_MODULE_VERSION
Expand Down
7 changes: 0 additions & 7 deletions src/util.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,7 @@

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wcast-function-type"
#endif
#include "v8.h"
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic pop
#endif

#include <climits>
#include <cstddef>
Expand Down

0 comments on commit 4128eef

Please sign in to comment.