Skip to content

Commit

Permalink
build: do not copy v8-inspector* headers ar part of install
Browse files Browse the repository at this point in the history
These headers are exposed from V8 for embedder and should not be
used by native addons.

Fixes #22415

PR-URL: #22586
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
alexkozy authored and addaleax committed Aug 31, 2018
1 parent 21e8ce2 commit 4b47d29
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion tools/install.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,14 @@ def files(action):
headers(action)

def headers(action):
def ignore_inspector_headers(files, dest):
inspector_headers = [
'deps/v8/include/v8-inspector.h',
'deps/v8/include/v8-inspector-protocol.h'
]
files = filter(lambda name: name not in inspector_headers, files)
action(files, dest)

action([
'common.gypi',
'config.gypi',
Expand All @@ -172,7 +180,7 @@ def headers(action):
if sys.platform.startswith('aix'):
action(['out/Release/node.exp'], 'include/node/')

subdir_files('deps/v8/include', 'include/node/', action)
subdir_files('deps/v8/include', 'include/node/', ignore_inspector_headers)

if 'false' == variables.get('node_shared_libuv'):
subdir_files('deps/uv/include', 'include/node/', action)
Expand Down

0 comments on commit 4b47d29

Please sign in to comment.