From 4bc54238b2fe19fa5942ee2748535bc989df894a Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 23 Feb 2018 16:29:45 -0800 Subject: [PATCH] doc: update 2fa information in onboarding.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Because it is no longer possible to add someone to the nodejs GitHub organization if they do not have two-factor authentication enabled, update the text of the onboarding documentatino to reflect this. PR-URL: https://github.com/nodejs/node/pull/18968 Reviewed-By: Vse Mozhet Byt Reviewed-By: Сковорода Никита Андреевич Reviewed-By: Weijia Wang Reviewed-By: Luigi Pinca Reviewed-By: Shingo Inoue Reviewed-By: Colin Ihrig Reviewed-By: Ruben Bridgewater Reviewed-By: Matheus Marchini --- doc/onboarding.md | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index 352a181f4dce8e..a85e493d3c7561 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -5,10 +5,10 @@ onboarding session. ## One week before the onboarding session -* Confirm that the new Collaborator is using two-factor authentication on their - GitHub account. Unless two-factor authentication is enabled, do not give an - account elevated privileges such as the ability to land code in the main - repository or to start continuous integration (CI) jobs. +* If the new Collaborator is not yet a member of the nodejs GitHub organization, + confirm that they are using two-factor authentication. It will not be possible + to add them to the organization if they are not using two-factor + authentication. * Announce the accepted nomination in a TSC meeting and in the TSC mailing list. @@ -16,9 +16,6 @@ onboarding session. * Prior to the onboarding session, add the new Collaborator to [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators). - Note that this is the step that gives the account elevated privileges, so do - not perform this step (or any subsequent steps) unless two-factor - authentication is enabled on the new Collaborator's GitHub account. ## Onboarding session