Skip to content

Commit

Permalink
tools: fetch googletest dependency for V8 CI
Browse files Browse the repository at this point in the history
gtest_prod.h is not enough to build V8's cctests.

Backport-PR-URL: #39470
PR-URL: #38990
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
targos authored and BethGriggs committed Jul 29, 2021
1 parent a93e6ef commit 5517769
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tools/v8/fetch_deps.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"custom_deps" : {
# These deps are already part of Node.js.
"v8/base/trace_event/common" : None,
"v8/third_party/googletest/src" : None,
# These deps are unnecessary for building.
"v8/test/benchmarks/data" : None,
"v8/testing/gmock" : None,
Expand Down

0 comments on commit 5517769

Please sign in to comment.