From 56dda6f33625148387bec2c0b8fcb9b237605017 Mon Sep 17 00:00:00 2001 From: Benjamin Gruenbaum Date: Tue, 22 Mar 2016 12:11:40 +0200 Subject: [PATCH] fs: Remove unused branches a few places the code was refactored to use `maybeCallback` which always returns a function. Checking for `if (callback)` always returns true anyway. PR-URL: https://github.com/nodejs/node/pull/5289 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: thefourtheye --- lib/fs.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/fs.js b/lib/fs.js index 3deb3090fd9731..64978efb9d0b2c 100644 --- a/lib/fs.js +++ b/lib/fs.js @@ -1098,7 +1098,7 @@ function writeAll(fd, buffer, offset, length, position, callback_) { fs.write(fd, buffer, offset, length, position, function(writeErr, written) { if (writeErr) { fs.close(fd, function() { - if (callback) callback(writeErr); + callback(writeErr); }); } else { if (written === length) { @@ -1131,7 +1131,7 @@ fs.writeFile = function(path, data, options, callback_) { var flag = options.flag || 'w'; fs.open(path, flag, options.mode, function(openErr, fd) { if (openErr) { - if (callback) callback(openErr); + callback(openErr); } else { var buffer = (data instanceof Buffer) ? data : new Buffer('' + data, options.encoding || 'utf8');