-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build,tools: make addons tests work with GN
PR-URL: #50737 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
- Loading branch information
1 parent
9be6b7c
commit 5911731
Showing
9 changed files
with
469 additions
and
331 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,145 @@ | ||
| #!/usr/bin/env python3 | ||
|
|
||
| import argparse | ||
| import os | ||
| import shutil | ||
| import subprocess | ||
| import sys | ||
| import tempfile | ||
| from concurrent.futures import ThreadPoolExecutor | ||
|
|
||
| ROOT_DIR = os.path.abspath(os.path.join(__file__, '..', '..')) | ||
|
|
||
| # Run install.py to install headers. | ||
| def generate_headers(headers_dir, install_args): | ||
| print('Generating headers') | ||
| subprocess.check_call([ | ||
| sys.executable, | ||
| os.path.join(ROOT_DIR, 'tools/install.py'), | ||
| 'install', | ||
| '--silent', | ||
| '--headers-only', | ||
| '--prefix', '/', | ||
| '--dest-dir', headers_dir, | ||
| ] + install_args) | ||
|
|
||
| # Rebuild addons in parallel. | ||
| def rebuild_addons(args): | ||
| headers_dir = os.path.abspath(args.headers_dir) | ||
| out_dir = os.path.abspath(args.out_dir) | ||
| node_bin = os.path.join(out_dir, 'node') | ||
| if args.is_win: | ||
| node_bin += '.exe' | ||
|
|
||
| if os.path.isabs(args.node_gyp): | ||
| node_gyp = args.node_gyp | ||
| else: | ||
| node_gyp = os.path.join(ROOT_DIR, args.node_gyp) | ||
|
|
||
| # Copy node.lib. | ||
| if args.is_win: | ||
| node_lib_dir = os.path.join(headers_dir, 'Release') | ||
| os.makedirs(node_lib_dir) | ||
| shutil.copy2(os.path.join(args.out_dir, 'node.lib'), | ||
| os.path.join(node_lib_dir, 'node.lib')) | ||
|
|
||
| def node_gyp_rebuild(test_dir): | ||
| print('Building addon in', test_dir) | ||
| try: | ||
| process = subprocess.Popen([ | ||
| node_bin, | ||
| node_gyp, | ||
| 'rebuild', | ||
| '--directory', test_dir, | ||
| '--nodedir', headers_dir, | ||
| '--python', sys.executable, | ||
| '--loglevel', args.loglevel, | ||
| ], stdout=subprocess.PIPE, stderr=subprocess.PIPE) | ||
|
|
||
| # We buffer the output and print it out once the process is done in order | ||
| # to avoid interleaved output from multiple builds running at once. | ||
| return_code = process.wait() | ||
| stdout, stderr = process.communicate() | ||
| if return_code != 0: | ||
| print(f'Failed to build addon in {test_dir}:') | ||
| if stdout: | ||
| print(stdout.decode()) | ||
| if stderr: | ||
| print(stderr.decode()) | ||
|
|
||
| except Exception as e: | ||
| print(f'Unexpected error when building addon in {test_dir}. Error: {e}') | ||
|
|
||
| test_dirs = [] | ||
| skip_tests = args.skip_tests.split(',') | ||
| only_tests = args.only_tests.split(',') if args.only_tests else None | ||
| for child_dir in os.listdir(args.target): | ||
| full_path = os.path.join(args.target, child_dir) | ||
| if not os.path.isdir(full_path): | ||
| continue | ||
| if 'binding.gyp' not in os.listdir(full_path): | ||
| continue | ||
| if child_dir in skip_tests: | ||
| continue | ||
| if only_tests and child_dir not in only_tests: | ||
| continue | ||
| test_dirs.append(full_path) | ||
|
|
||
| with ThreadPoolExecutor() as executor: | ||
| executor.map(node_gyp_rebuild, test_dirs) | ||
|
|
||
| def get_default_out_dir(args): | ||
| default_out_dir = os.path.join('out', 'Release') | ||
| if not args.is_win: | ||
| # POSIX platforms only have one out dir. | ||
| return default_out_dir | ||
| # On Windows depending on the args of GYP and configure script, the out dir | ||
| # could be 'out/Release' or just 'Release'. | ||
| if os.path.exists(default_out_dir): | ||
| return default_out_dir | ||
| if os.path.exists('Release'): | ||
| return 'Release' | ||
| raise RuntimeError('Can not find out dir, did you run configure?') | ||
|
|
||
| def main(): | ||
| if sys.platform == 'cygwin': | ||
| raise RuntimeError('This script does not support running with cygwin python.') | ||
|
|
||
| parser = argparse.ArgumentParser( | ||
| description='Install headers and rebuild child directories') | ||
| parser.add_argument('target', help='target directory to build addons') | ||
| parser.add_argument('--headers-dir', | ||
| help='path to node headers directory, if not specified ' | ||
| 'new headers will be generated for building', | ||
| default=None) | ||
| parser.add_argument('--out-dir', help='path to the output directory', | ||
| default=None) | ||
| parser.add_argument('--loglevel', help='loglevel of node-gyp', | ||
| default='silent') | ||
| parser.add_argument('--skip-tests', help='skip building tests', | ||
| default='') | ||
| parser.add_argument('--only-tests', help='only build tests in the list', | ||
| default='') | ||
| parser.add_argument('--node-gyp', help='path to node-gyp script', | ||
| default='deps/npm/node_modules/node-gyp/bin/node-gyp.js') | ||
| parser.add_argument('--is-win', help='build for Windows target', | ||
| action='store_true', default=(sys.platform == 'win32')) | ||
| args, unknown_args = parser.parse_known_args() | ||
|
|
||
| if not args.out_dir: | ||
| args.out_dir = get_default_out_dir(args) | ||
|
|
||
| if args.headers_dir: | ||
| rebuild_addons(args) | ||
| else: | ||
| # When --headers-dir is not specified, generate headers into a temp dir and | ||
| # build with the new headers. | ||
| try: | ||
| args.headers_dir = tempfile.mkdtemp() | ||
| generate_headers(args.headers_dir, unknown_args) | ||
| rebuild_addons(args) | ||
| finally: | ||
| shutil.rmtree(args.headers_dir) | ||
|
|
||
| if __name__ == '__main__': | ||
| main() |
Oops, something went wrong.