From 5a1afb2139efad97733bba4aff6d14a6896525e0 Mon Sep 17 00:00:00 2001 From: Colin Ihrig Date: Wed, 31 Jul 2024 09:53:31 -0400 Subject: [PATCH] test_runner: remove outdated comment Network imports were removed, so remove the comment. Refs: https://github.com/nodejs/node/pull/53822 PR-URL: https://github.com/nodejs/node/pull/54146 Reviewed-By: Luigi Pinca Reviewed-By: Jake Yuesong Li Reviewed-By: Trivikram Kamat Reviewed-By: Moshe Atlow --- lib/test/mock_loader.js | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/test/mock_loader.js b/lib/test/mock_loader.js index 307ad980856094..35b0ee82df79f2 100644 --- a/lib/test/mock_loader.js +++ b/lib/test/mock_loader.js @@ -36,13 +36,6 @@ const { createRequire, isBuiltin } = require('module'); // https://github.com/nodejs/node/issues/49472 // or https://github.com/nodejs/node/issues/52219 -// TODO(cjihrig): Network imports should be supported. There are two current -// hurdles: -// - The module format returned by the load() hook is not known. This could be -// implemented as an option, or default to 'module' for network imports. -// - The generated mock module imports 'node:test', which is not allowed by -// checkIfDisallowedImport() in the ESM code. - const mocks = new SafeMap(); async function initialize(data) {