From 663b6251a0a53ef37ae4bca233c5bf3d639259d5 Mon Sep 17 00:00:00 2001 From: Vse Mozhet Byt Date: Sun, 10 Feb 2019 03:26:12 +0200 Subject: [PATCH] doc: fix some nits in perf_hooks PR-URL: https://github.com/nodejs/node/pull/26022 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott Reviewed-By: Gireesh Punathil Reviewed-By: Colin Ihrig Reviewed-By: Anto Aravinth Reviewed-By: Sakthipriyan Vairamani Reviewed-By: James M Snell --- doc/api/perf_hooks.md | 37 ++++++++++++++++++++++++++++--------- tools/doc/type-parser.js | 3 +-- 2 files changed, 29 insertions(+), 11 deletions(-) diff --git a/doc/api/perf_hooks.md b/doc/api/perf_hooks.md index d805a0cf9de4d9..dd65c0d0bf9481 100644 --- a/doc/api/perf_hooks.md +++ b/doc/api/perf_hooks.md @@ -398,14 +398,14 @@ Returns a list of `PerformanceEntry` objects in chronological order with respect to `performanceEntry.startTime` whose `performanceEntry.entryType` is equal to `type`. -## monitorEventLoopDelay([options]) +## perf_hooks.monitorEventLoopDelay([options]) * `options` {Object} * `resolution` {number} The sampling rate in milliseconds. Must be greater - than zero. Defaults to `10`. + than zero. **Default:** `10`. * Returns: {Histogram} Creates a `Histogram` object that samples and reports the event loop delay @@ -421,7 +421,7 @@ detect. const { monitorEventLoopDelay } = require('perf_hooks'); const h = monitorEventLoopDelay({ resolution: 20 }); h.enable(); -// Do something +// Do something. h.disable(); console.log(h.min); console.log(h.max); @@ -459,21 +459,30 @@ Enables the event loop delay sample timer. Returns `true` if the timer was started, `false` if it was already started. #### histogram.exceeds + -* Value: {number} +* {number} The number of times the event loop delay exceeded the maximum 1 hour event loop delay threshold. #### histogram.max + -* Value: {number} +* {number} The maximum recorded event loop delay. #### histogram.mean + -* Value: {number} +* {number} The mean of the recorded event loop delays. @@ -482,19 +491,26 @@ The mean of the recorded event loop delays. added: REPLACEME --> -* Value: {number} +* {number} The minimum recorded event loop delay. #### histogram.percentile(percentile) + * `percentile` {number} A percentile value between 1 and 100. +* Returns: {number} Returns the value at the given percentile. #### histogram.percentiles + -* Value: {Map} +* {Map} Returns a `Map` object detailing the accumulated percentile distribution. @@ -506,8 +522,11 @@ added: REPLACEME Resets the collected histogram data. #### histogram.stddev + -* Value: {number} +* {number} The standard deviation of the recorded event loop delays. diff --git a/tools/doc/type-parser.js b/tools/doc/type-parser.js index ffbec9115c272e..c11ec2604d018b 100644 --- a/tools/doc/type-parser.js +++ b/tools/doc/type-parser.js @@ -75,8 +75,6 @@ const customTypesMap = { 'fs.Stats': 'fs.html#fs_class_fs_stats', 'fs.WriteStream': 'fs.html#fs_class_fs_writestream', - 'Histogram': 'perf_hooks.html#perf_hooks_class_histogram', - 'http.Agent': 'http.html#http_class_http_agent', 'http.ClientRequest': 'http.html#http_class_http_clientrequest', 'http.IncomingMessage': 'http.html#http_class_http_incomingmessage', @@ -107,6 +105,7 @@ const customTypesMap = { 'os.constants.dlopen': 'os.html#os_dlopen_constants', + 'Histogram': 'perf_hooks.html#perf_hooks_class_histogram', 'PerformanceEntry': 'perf_hooks.html#perf_hooks_class_performanceentry', 'PerformanceNodeTiming': 'perf_hooks.html#perf_hooks_class_performancenodetiming_extends_performanceentry', // eslint-disable-line max-len