Skip to content

Commit

Permalink
build: temporarily skip ASAN build
Browse files Browse the repository at this point in the history
GitHub Actions doesn't have enough memory to complete an ASAN+Debug with
V8 8.1. Don't take ASAN into account on CI results until we find a
workaround, or until we upgrade to V8 8.2.

PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
mmarchini committed Mar 18, 2020
1 parent d19a2c3 commit 6a34901
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/ASAN.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Build
# TODO(mmarchini): With V8 8.1, GitHub Actions doesn't have enough
# memory to build with debug and ASAN. Allow this build to fail until
# we figure out a workaround, or until we update to 8.2 (where build
# is passing).
continue-on-error: true
run: |
npx envinfo
./configure --debug --enable-asan --ninja && ninja -C out/Debug
Expand Down

0 comments on commit 6a34901

Please sign in to comment.