From 6e56f2db52383ae854cc958bcb0504a442b0c4c4 Mon Sep 17 00:00:00 2001
From: Joyee Cheung <joyeec9h3@gmail.com>
Date: Thu, 14 Sep 2023 23:23:46 +0200
Subject: [PATCH] test: skip test-child-process-stdio-reuse-readable-stdio on
 Windows
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

It is flaky due to the same cause of test-child-process-pipe-dataflow
being flaky - cygwin quirks - so skip it on Windows too.

Drive-by: remove the skip mark of test-child-process-pipe-dataflow
in the status file and directly skip it in the test with a comment.

PR-URL: https://github.com/nodejs/node/pull/49621
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
---
 test/parallel/parallel.status                               | 3 ---
 test/parallel/test-child-process-pipe-dataflow.js           | 6 ++++++
 .../test-child-process-stdio-reuse-readable-stdio.js        | 6 ++++++
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
index 84888f12635aaf..6f4b9de73778b2 100644
--- a/test/parallel/parallel.status
+++ b/test/parallel/parallel.status
@@ -11,9 +11,6 @@ prefix parallel
 test-crypto-keygen: PASS,FLAKY
 # https://github.com/nodejs/node/issues/41201
 test-fs-rmdir-recursive: PASS, FLAKY
-# https://github.com/nodejs/node/issues/48300
-test-child-process-pipe-dataflow: SKIP
-test-child-process-stdio-reuse-readable-stdio: PASS, FLAKY
 
 # Windows on ARM
 [$system==win32 && $arch==arm64]
diff --git a/test/parallel/test-child-process-pipe-dataflow.js b/test/parallel/test-child-process-pipe-dataflow.js
index 257f4046aa6b99..e61bcde5b035d2 100644
--- a/test/parallel/test-child-process-pipe-dataflow.js
+++ b/test/parallel/test-child-process-pipe-dataflow.js
@@ -1,5 +1,11 @@
 'use strict';
 const common = require('../common');
+
+if (common.isWindows) {
+  // https://github.com/nodejs/node/issues/48300
+  common.skip('Does not work with cygwin quirks on Windows');
+}
+
 const assert = require('assert');
 const fs = require('fs');
 const spawn = require('child_process').spawn;
diff --git a/test/parallel/test-child-process-stdio-reuse-readable-stdio.js b/test/parallel/test-child-process-stdio-reuse-readable-stdio.js
index 263270f8e8891f..19f746e25952df 100644
--- a/test/parallel/test-child-process-stdio-reuse-readable-stdio.js
+++ b/test/parallel/test-child-process-stdio-reuse-readable-stdio.js
@@ -1,5 +1,11 @@
 'use strict';
 const common = require('../common');
+
+if (common.isWindows) {
+  // https://github.com/nodejs/node/issues/48300
+  common.skip('Does not work with cygwin quirks on Windows');
+}
+
 const assert = require('assert');
 const { spawn } = require('child_process');