From 6f35e4421a3df92b6809e07053bf23cb811ecbec Mon Sep 17 00:00:00 2001 From: Evan Lucas Date: Wed, 19 Oct 2016 16:28:16 -0500 Subject: [PATCH] http: add debug message for invalid header value This makes it easier to see what header has an invalid value. PR-URL: https://github.com/nodejs/node/pull/9195 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Brian White --- lib/_http_outgoing.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js index 09459480565413..b85e3c54074d82 100644 --- a/lib/_http_outgoing.js +++ b/lib/_http_outgoing.js @@ -317,6 +317,7 @@ function storeHeader(self, state, field, value) { 'Header name must be a valid HTTP Token ["' + field + '"]'); } if (common._checkInvalidHeaderChar(value) === true) { + debug('Header "%s" contains invalid characters', field); throw new TypeError('The header content contains invalid characters'); } state.messageHeader += field + ': ' + escapeHeaderValue(value) + CRLF; @@ -357,6 +358,7 @@ OutgoingMessage.prototype.setHeader = function setHeader(name, value) { if (this._header) throw new Error('Can\'t set headers after they are sent.'); if (common._checkInvalidHeaderChar(value) === true) { + debug('Header "%s" contains invalid characters', name); throw new TypeError('The header content contains invalid characters'); } if (this._headers === null) @@ -534,6 +536,7 @@ OutgoingMessage.prototype.addTrailers = function addTrailers(headers) { 'Trailer name must be a valid HTTP Token ["' + field + '"]'); } if (common._checkInvalidHeaderChar(value) === true) { + debug('Trailer "%s" contains invalid characters', field); throw new TypeError('The trailer content contains invalid characters'); } this._trailer += field + ': ' + escapeHeaderValue(value) + CRLF;