Skip to content

Commit

Permalink
build: skip bin override on windows
Browse files Browse the repository at this point in the history
PR-URL: #16460
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
  • Loading branch information
digitalinfinity authored and MylesBorins committed Nov 28, 2017
1 parent c64ed97 commit 706812b
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -1319,7 +1319,9 @@ def configure_inspector(o):
o['variables']['v8_inspector'] = b(not disable_inspector)


def get_bin_override():
def make_bin_override():
if sys.platform == 'win32':
raise Exception('make_bin_override should not be called on win32.')
# If the system python is not the python we are running (which should be
# python 2), then create a directory with a symlink called `python` to our
# sys.executable. This directory will be prefixed to the PATH, so that
Expand Down Expand Up @@ -1426,7 +1428,8 @@ if options.prefix:

config = '\n'.join(map('='.join, config.iteritems())) + '\n'

bin_override = get_bin_override()
# On Windows there's no reason to search for a different python binary.
bin_override = None if sys.platform == 'win32' else make_bin_override()
if bin_override:
config = 'export PATH:=' + bin_override + ':$(PATH)\n' + config

Expand Down

0 comments on commit 706812b

Please sign in to comment.