From 708f57ea49a6e1f7df6e70a064b9fafc39a6fa9f Mon Sep 17 00:00:00 2001
From: marco-ippolito <marcoippolito54@gmail.com>
Date: Mon, 29 Apr 2024 10:41:03 +0200
Subject: [PATCH] util: move util.isNumber to eol
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PR-URL: https://github.com/nodejs/node/pull/52744
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 doc/api/deprecations.md    |  8 +++++---
 doc/api/util.md            | 27 ---------------------------
 lib/util.js                | 12 ------------
 test/parallel/test-util.js |  4 ----
 4 files changed, 5 insertions(+), 46 deletions(-)

diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
index f99a5bce4b358b..315ba4a44ac41d 100644
--- a/doc/api/deprecations.md
+++ b/doc/api/deprecations.md
@@ -1177,6 +1177,9 @@ The `util.isNullOrUndefined()` API has been removed. Please use
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/52744
+    description: End-of-Life deprecation.
   - version: v22.0.0
     pr-url: https://github.com/nodejs/node/pull/50488
     description: Runtime deprecation.
@@ -1192,9 +1195,9 @@ changes:
     description: Documentation-only deprecation.
 -->
 
-Type: Runtime
+Type: End-of-Life
 
-The [`util.isNumber()`][] API is deprecated. Please use
+The `util.isNumber()` API has been removed. Please use
 `typeof arg === 'number'` instead.
 
 ### DEP0053: `util.isObject()`
@@ -3790,7 +3793,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][].
 [`util.isArray()`]: util.md#utilisarrayobject
 [`util.isError()`]: util.md#utiliserrorobject
 [`util.isFunction()`]: util.md#utilisfunctionobject
-[`util.isNumber()`]: util.md#utilisnumberobject
 [`util.isObject()`]: util.md#utilisobjectobject
 [`util.isPrimitive()`]: util.md#utilisprimitiveobject
 [`util.isRegExp()`]: util.md#utilisregexpobject
diff --git a/doc/api/util.md b/doc/api/util.md
index a942c2447a11f4..8798e39e1de80b 100644
--- a/doc/api/util.md
+++ b/doc/api/util.md
@@ -3045,33 +3045,6 @@ util.isFunction(Bar);
 // Returns: true
 ```
 
-### `util.isNumber(object)`
-
-<!-- YAML
-added: v0.11.5
-deprecated: v4.0.0
--->
-
-> Stability: 0 - Deprecated: Use `typeof value === 'number'` instead.
-
-* `object` {any}
-* Returns: {boolean}
-
-Returns `true` if the given `object` is a `Number`. Otherwise, returns `false`.
-
-```js
-const util = require('node:util');
-
-util.isNumber(false);
-// Returns: false
-util.isNumber(Infinity);
-// Returns: true
-util.isNumber(0);
-// Returns: true
-util.isNumber(NaN);
-// Returns: true
-```
-
 ### `util.isObject(object)`
 
 <!-- YAML
diff --git a/lib/util.js b/lib/util.js
index 90d9cb48c385e9..996de083320517 100644
--- a/lib/util.js
+++ b/lib/util.js
@@ -90,15 +90,6 @@ function lazyAbortController() {
 
 let internalDeepEqual;
 
-/**
- * @deprecated since v4.0.0
- * @param {any} arg
- * @returns {arg is number}
- */
-function isNumber(arg) {
-  return typeof arg === 'number';
-}
-
 /**
  * @param {any} arg
  * @returns {arg is string}
@@ -398,9 +389,6 @@ module.exports = {
     }
     return internalDeepEqual(a, b);
   },
-  isNumber: deprecate(isNumber,
-                      'The `util.isNumber` API is deprecated. Please use `typeof arg === "number"` instead.',
-                      'DEP0052'),
   isString: deprecate(isString,
                       'The `util.isString` API is deprecated.  Please use `typeof arg === "string"` instead.',
                       'DEP0056'),
diff --git a/test/parallel/test-util.js b/test/parallel/test-util.js
index 1330c5972be015..4b8b27aaf097a4 100644
--- a/test/parallel/test-util.js
+++ b/test/parallel/test-util.js
@@ -103,10 +103,6 @@ assert.strictEqual(util.isUndefined(), true);
 assert.strictEqual(util.isUndefined(null), false);
 assert.strictEqual(util.isUndefined('string'), false);
 
-assert.strictEqual(util.isNumber(42), true);
-assert.strictEqual(util.isNumber(), false);
-assert.strictEqual(util.isNumber('string'), false);
-
 assert.strictEqual(util.isString('string'), true);
 assert.strictEqual(util.isString(), false);
 assert.strictEqual(util.isString(42), false);