From 735ef8b235a186a476f4b3bfa6c172b680bb24d6 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Mon, 2 Sep 2019 10:31:27 +0200 Subject: [PATCH] doc: async_hooks.createHook promiseResolve option MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Document the `promiseResolve` option to `async_hooks.createHook()`. This seems to have been overlooked in commit b605b15346 ("async_hooks: support promise resolve hook") from September 2017. It is documented elsewhere in the async_hooks API documentation, except where you actually pass it in. PR-URL: https://github.com/nodejs/node/pull/29405 Reviewed-By: David Carlier Reviewed-By: Michaël Zasso Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: James M Snell --- doc/api/async_hooks.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/api/async_hooks.md b/doc/api/async_hooks.md index 487f3ac9c13c5f..90ff343ae0817c 100644 --- a/doc/api/async_hooks.md +++ b/doc/api/async_hooks.md @@ -89,6 +89,7 @@ added: v8.1.0 * `before` {Function} The [`before` callback][]. * `after` {Function} The [`after` callback][]. * `destroy` {Function} The [`destroy` callback][]. + * `promiseResolve` {Function} The [`promiseResolve` callback][]. * Returns: {AsyncHook} Instance used for disabling and enabling hooks Registers functions to be called for different lifetime events of each async @@ -685,6 +686,7 @@ never be called. [`before` callback]: #async_hooks_before_asyncid [`destroy` callback]: #async_hooks_destroy_asyncid [`init` callback]: #async_hooks_init_asyncid_type_triggerasyncid_resource +[`promiseResolve` callback]: #async_hooks_promiseresolve_asyncid [Hook Callbacks]: #async_hooks_hook_callbacks [PromiseHooks]: https://docs.google.com/document/d/1rda3yKGHimKIhg5YeoAmCOtyURgsbTH_qaYR79FELlk/edit [`Worker`]: worker_threads.html#worker_threads_class_worker