diff --git a/src/api/hooks.cc b/src/api/hooks.cc index 2dd0cc994ea7f2..d0113670457401 100644 --- a/src/api/hooks.cc +++ b/src/api/hooks.cc @@ -30,7 +30,10 @@ void AtExit(Environment* env, void (*cb)(void* arg), void* arg) { } void EmitBeforeExit(Environment* env) { - env->RunBeforeExitCallbacks(); + TraceEventScope trace_scope(TRACING_CATEGORY_NODE1(environment), + "BeforeExit", env); + if (!env->destroy_async_id_list()->empty()) + AsyncWrap::DestroyAsyncIdsCallback(env); HandleScope handle_scope(env->isolate()); Context::Scope context_scope(env->context()); diff --git a/src/env.cc b/src/env.cc index 657d711e539d81..34f5adccc2e0b5 100644 --- a/src/env.cc +++ b/src/env.cc @@ -366,13 +366,6 @@ Environment::Environment(IsolateData* isolate_data, } destroy_async_id_list_.reserve(512); - BeforeExit( - [](void* arg) { - Environment* env = static_cast(arg); - if (!env->destroy_async_id_list()->empty()) - AsyncWrap::DestroyAsyncIdsCallback(env); - }, - this); performance_state_ = std::make_unique(isolate()); @@ -640,19 +633,6 @@ void Environment::RunCleanup() { } } -void Environment::RunBeforeExitCallbacks() { - TraceEventScope trace_scope(TRACING_CATEGORY_NODE1(environment), - "BeforeExit", this); - for (ExitCallback before_exit : before_exit_functions_) { - before_exit.cb_(before_exit.arg_); - } - before_exit_functions_.clear(); -} - -void Environment::BeforeExit(void (*cb)(void* arg), void* arg) { - before_exit_functions_.push_back(ExitCallback{cb, arg}); -} - void Environment::RunAtExitCallbacks() { TraceEventScope trace_scope(TRACING_CATEGORY_NODE1(environment), "AtExit", this); diff --git a/src/env.h b/src/env.h index 6de5ba9b192dd1..27d99e53e8ea65 100644 --- a/src/env.h +++ b/src/env.h @@ -1118,8 +1118,6 @@ class Environment : public MemoryRetainer { const char* name, v8::FunctionCallback callback); - void BeforeExit(void (*cb)(void* arg), void* arg); - void RunBeforeExitCallbacks(); void AtExit(void (*cb)(void* arg), void* arg); void RunAtExitCallbacks(); @@ -1394,7 +1392,6 @@ class Environment : public MemoryRetainer { void (*cb_)(void* arg); void* arg_; }; - std::list before_exit_functions_; std::list at_exit_functions_;