Skip to content

Commit

Permalink
test: changed function to arrow function
Browse files Browse the repository at this point in the history
Convert callback functions that are anonymous
to arrow functions for better readability.
Also adjusted the `this` object in places
where that was required.

PR-URL: #28726
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
HarshithaKP authored and targos committed Jul 20, 2019
1 parent be32bec commit 7989d5c
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions test/parallel/test-http-wget.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,38 +40,38 @@ const http = require('http');
// content-length is not provided, that the connection is in fact
// closed.

const server = http.createServer(function(req, res) {
const server = http.createServer((req, res) => {
res.writeHead(200, { 'Content-Type': 'text/plain' });
res.write('hello ');
res.write('world\n');
res.end();
});
server.listen(0);

server.on('listening', common.mustCall(function() {
const c = net.createConnection(this.address().port);
server.on('listening', common.mustCall(() => {
const c = net.createConnection(server.address().port);
let server_response = '';

c.setEncoding('utf8');

c.on('connect', function() {
c.on('connect', () => {
c.write('GET / HTTP/1.0\r\n' +
'Connection: Keep-Alive\r\n\r\n');
});

c.on('data', function(chunk) {
c.on('data', (chunk) => {
console.log(chunk);
server_response += chunk;
});

c.on('end', common.mustCall(function() {
c.on('end', common.mustCall(() => {
const m = server_response.split('\r\n\r\n');
assert.strictEqual(m[1], 'hello world\n');
console.log('got end');
c.end();
}));

c.on('close', common.mustCall(function() {
c.on('close', common.mustCall(() => {
console.log('got close');
server.close();
}));
Expand Down

0 comments on commit 7989d5c

Please sign in to comment.