Skip to content

Commit

Permalink
doc: update example ICU URL
Browse files Browse the repository at this point in the history
PR-URL: #35373
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
watilde authored and danielleadams committed Oct 6, 2020
1 parent 4d29fb5 commit 79e3e50
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions doc/guides/maintaining-icu.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ V8 will not compile.

```c
// deps/v8/src/objects/intl-objects.h
#define V8_MINIMUM_ICU_VERSION 64
#define V8_MINIMUM_ICU_VERSION 65
```
V8 in Node.js depends on the ICU version supplied by Node.js.
Expand All @@ -104,7 +104,7 @@ should be sufficient).
```bash
./configure \
--with-intl=full-icu \
--with-icu-source=http://download.icu-project.org/files/icu4c/58.1/icu4c-58_1-src.tgz
--with-icu-source=https://github.com/unicode-org/icu/releases/download/release-67-1/icu4c-67_1-src.tgz
make
```

Expand Down

0 comments on commit 79e3e50

Please sign in to comment.