Skip to content

Commit

Permalink
deps: V8: cherry-pick 215ccd593edb
Browse files Browse the repository at this point in the history
Original commit message:

    Use FlagValue::value() in SLOW_DCHECK

    Previously SLOW_DCHECK used the non-constexpr bool() operator
    of FlagValue, which cannot be used in constexpr. Switch to
    FlagValue::value() instead for make it compile in constexpr.

    Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495
    Reviewed-by: Jakob Linke <jgruber@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#86611}

Refs: v8/v8@215ccd5
PR-URL: #47212
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
  • Loading branch information
joyeecheung authored and RafaelGSS committed Apr 7, 2023
1 parent 7a2090c commit 7a4beaa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.14',
'v8_embedder_string': '-node.15',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/common/checks.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

#ifdef ENABLE_SLOW_DCHECKS
#define SLOW_DCHECK(condition) \
CHECK(!v8::internal::FLAG_enable_slow_asserts || (condition))
CHECK(!v8::internal::v8_flags.enable_slow_asserts.value() || (condition))
#define SLOW_DCHECK_IMPLIES(lhs, rhs) SLOW_DCHECK(!(lhs) || (rhs))
#else
#define SLOW_DCHECK(condition) ((void)0)
Expand Down

0 comments on commit 7a4beaa

Please sign in to comment.